Skip to content

Remove some copy/paste constructors and unify them in one templated c… #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Cat-Ion wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Remove some copy/paste constructors and unify them in one templated c… #45

Cat-Ion wants to merge 2 commits into from

Conversation

@Cat-Ion
Copy link
Owner

@Cat-Ion Cat-Ion commented Oct 11, 2018

…onstructor

@coveralls
Copy link

coveralls commented Oct 11, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-100.0%) to 0.0% when pulling 97e67f1 on feature/template-constructors into 8e36d82 on master.

@Cat-Ion Cat-Ion force-pushed the feature/template-constructors branch 4 times, most recently from f01f17a to a302f78 Compare October 11, 2018 20:06
@Cat-Ion
Copy link
Owner Author

Cat-Ion commented Oct 11, 2018

Oh god I hate compilers

@Cat-Ion Cat-Ion force-pushed the feature/template-constructors branch 9 times, most recently from d84572a to c1f7686 Compare October 11, 2018 20:57
@Cat-Ion Cat-Ion force-pushed the feature/template-constructors branch from c1f7686 to af0ac59 Compare October 11, 2018 20:59
@Cat-Ion
Copy link
Owner Author

Cat-Ion commented Oct 11, 2018

Guess I'll let this one rest until coveralls works with gcc-8... and maybe clang works as it should.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Cat-Ion @coveralls