Use absolute require file paths #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dd32
commented
Apr 1, 2022
| @@ -27,13 +27,13 @@ | |||
|
|
|||
| use SeriouslySimpleStats\Classes\Stats; | |||
|
|
|||
| require_once 'vendor/autoload.php'; | |||
|
|
|||
| define( 'SSP_STATS_VERSION', '1.3.0' ); | |||
| define( 'SSP_STATS_DIR_PATH', trailingslashit( plugin_dir_path( __FILE__ ) ) ); | |||
There was a problem hiding this comment.
Additionally... this expands to this:
define( 'SSP_STATS_DIR_PATH', trailingslashit( trailingslashit( dirname( __FILE__ ) ) ) );
So it could just be:
Suggested change
| define( 'SSP_STATS_DIR_PATH', trailingslashit( plugin_dir_path( __FILE__ ) ) ); | |
| define( 'SSP_STATS_DIR_PATH', __DIR__ . '/' ); |
(I'll leave it up to the plugin maintainers if they want to commit this suggestion too)
|
Am upvoting this like a [expletive]. |
davidhund
added a commit
to ICTU/ictuwp-plugin-Seriously-Simple-Stats-Overrides
that referenced
this pull request
Jul 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a WordPress install has a
ABSPATH . 'vendor/autoload.php'file, that will be included here instead of__DIR__ . 'vendor/autoload.php', ultimately causing a PHP fatal error.This is because PHP resolves relative paths relative to the current working directory (which is the web entry point at
ABSPATH . 'index.php') first before trying the current directory.Eg, in this case,
realpath( 'vendor/autoload.php' )returns/home/example.org/public_html/vendor/autoload.php.