Add the ability to associate arel table alias nodes to a search model#443
Open
sholden wants to merge 2 commits intoCasecommons:masterfrom
Open
Add the ability to associate arel table alias nodes to a search model#443sholden wants to merge 2 commits intoCasecommons:masterfrom
sholden wants to merge 2 commits intoCasecommons:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the ability to associate Arel::Nodes::TableAlias objects to a PgSearch::Model. This allows us to build an Arel AST directly to allow searching across relations where ActiveRecord won't support joins (in our use case and in the specs, this involves a polymorphic association), but you could imagine many more use cases where this feature could make the PgSearch::Model configuration much more flexible and extensible.
Example from spec: