Skip to content

Commit

Permalink
Remove Nose skipIf in favor of pytest
Browse files Browse the repository at this point in the history
  • Loading branch information
Carreau committed Aug 17, 2021
1 parent c36de65 commit fff924d
Showing 1 changed file with 8 additions and 3 deletions.
11 changes: 8 additions & 3 deletions ipykernel/tests/test_message_spec.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,10 @@
from queue import Empty

import nose.tools as nt
from nose.plugins.skip import SkipTest

import pytest

import jupyter_client

from traitlets import (
HasTraits, TraitError, Bool, Unicode, Dict, Integer, List, Enum
Expand Down Expand Up @@ -483,10 +486,12 @@ def test_connect_request():
validate_message(reply, 'connect_reply', msg_id)


@pytest.mark.skipif(
jupyter_client.version_info < (5, 0),
reason="earlier Jupyter Client don't have comm_info",
)
def test_comm_info_request():
flush_channels()
if not hasattr(KC, 'comm_info'):
raise SkipTest()
msg_id = KC.comm_info()
reply = get_reply(KC, msg_id, TIMEOUT)
validate_message(reply, 'comm_info_reply', msg_id)
Expand Down

0 comments on commit fff924d

Please sign in to comment.