Skip to content

Commit

Permalink
Remove impossible skipif.
Browse files Browse the repository at this point in the history
According to the dependencies in setup.py those will never be skipped.
  • Loading branch information
Carreau committed Jan 7, 2022
1 parent 4715b9b commit ca794bf
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 12 deletions.
7 changes: 0 additions & 7 deletions ipykernel/tests/test_async.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,21 +26,14 @@ def teardown_function():
KM.shutdown_kernel(now=True)


skip_without_async = pytest.mark.skipif(
sys.version_info < (3, 5) or V(IPython.__version__) < V("7.0"),
reason="IPython >=7 with async/await required",
)


@skip_without_async
def test_async_await():
flush_channels(KC)
msg_id, content = execute("import asyncio; await asyncio.sleep(0.1)", KC)
assert content["status"] == "ok", content


@pytest.mark.parametrize("asynclib", ["asyncio", "trio", "curio"])
@skip_without_async
def test_async_interrupt(asynclib, request):
try:
__import__(asynclib)
Expand Down
1 change: 0 additions & 1 deletion ipykernel/tests/test_eventloop.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ def teardown():
"""


@pytest.mark.skipif(sys.version_info < (3, 5), reason="async/await syntax required")
@pytest.mark.skipif(tornado.version_info < (5,), reason="only relevant on tornado 5")
def test_asyncio_interrupt():
flush_channels(KC)
Expand Down
4 changes: 0 additions & 4 deletions ipykernel/tests/test_kernel.py
Original file line number Diff line number Diff line change
Expand Up @@ -415,10 +415,6 @@ def test_interrupt_with_message():
validate_message(reply, 'execute_reply', msg_id)


@pytest.mark.skipif(
version.parse(IPython.__version__) < version.parse("7.14.0"),
reason="Need new IPython"
)
def test_interrupt_during_pdb_set_trace():
"""
The kernel exits after being interrupted while waiting in pdb.set_trace().
Expand Down

0 comments on commit ca794bf

Please sign in to comment.