Skip to content

Commit

Permalink
Remove colors_force flag
Browse files Browse the repository at this point in the history
See ipython/ipython#9673.

This will disable colours if ipykernel is installed with IPython <5, so
I'm bumping the IPython requirement in setup.py. So this probably can't
be merged until after IPython 5 is released.
  • Loading branch information
takluyver authored and Carreau committed Sep 25, 2018
1 parent acb1e39 commit 6625663
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
1 change: 0 additions & 1 deletion ipykernel/zmqshell.py
Original file line number Diff line number Diff line change
Expand Up @@ -453,7 +453,6 @@ def _default_banner1(self):
# Override the traitlet in the parent class, because there's no point using
# readline for the kernel. Can be removed when the readline code is moved
# to the terminal frontend.
colors_force = CBool(True)
readline_use = CBool(False)
# autoindent has no meaning in a zmqshell, and attempting to enable it
# will print a warning in the absence of readline.
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ def run(self):
keywords=['Interactive', 'Interpreter', 'Shell', 'Web'],
python_requires='>=3.4',
install_requires=[
'ipython>=4.0.0',
'ipython>=5.0.0',
'traitlets>=4.1.0',
'jupyter_client',
'tornado>=4.2',
Expand Down

0 comments on commit 6625663

Please sign in to comment.