Phones home at first start

[opk12]

Dear Maintainer,

On 0.24.1 from f-droid, when scrolling the intro slides at the first start, the app contacts donation.carnet.live and qn.phie.ovh without asking for consent. F-droid calls this privacy violation a Tracking AntiFeature to be marked on their app page. But is it really necessary? Thanks

[licaon-kter]

https://github.com/CarnetApp/CarnetAndroid/blob/5f25c4472d869b994f31317ccb36bcead6512a54/app/src/main/java/com/spisoft/quicknote/intro/SayHiFragment.java#L53
&
https://github.com/CarnetApp/CarnetAndroid/blob/ca1b4500eba7d6be7d255b68ea072a880c3cfe30/app/src/main/java/com/spisoft/quicknote/MainFragment.java#L237

:( https://github.com/CarnetApp/CarnetAndroid/blob/ca1b4500eba7d6be7d255b68ea072a880c3cfe30/app/src/main/res/values/strings.xml#L98

/LE: https://gitlab.com/fdroid/fdroiddata/-/commit/4d11ba005d6b8458611a6a02a23b00095e5e0bf9

[PhieF]

OK thanks, this is weird it should phone home only when pressing "say hi"

I do remember why this part is for:
https://github.com/CarnetApp/CarnetAndroid/blob/ca1b4500eba7d6be7d255b68ea072a880c3cfe30/app/src/main/java/com/spisoft/quicknote/MainFragment.java#L237

showing the current donations, I forgot that indeed this could be used for tracking, I will remove this once I have time

[IzzySoft]

Hi @PhieF, just a friendly reminder that the AF is still there. Please give us a ping when you released a new version where this is fixed, so we can remove the Tracking anti-feature from your app at F-Droid. Thanks!

[PhieF]

@IzzySoft
@licaon-kter
@opk12

done

I've removed this part https://github.com/CarnetApp/CarnetAndroid/blob/ca1b4500eba7d6be7d255b68ea072a880c3cfe30/app/src/main/java/com/spisoft/quicknote/MainFragment.java#L237

this one is kept

https://github.com/CarnetApp/CarnetAndroid/blob/5f25c4472d869b994f31317ccb36bcead6512a54/app/src/main/java/com/spisoft/quicknote/intro/SayHiFragment.java#L53

since it is perfectly explained that clicking on this button

https://github.com/CarnetApp/CarnetAndroid/blob/5f25c4472d869b994f31317ccb36bcead6512a54/app/src/main/res/values/strings.xml#L81

I could add a better explanation ? As you wish

I guess I haven't forgotten anything

[licaon-kter]

@PhieF Which version has this so I can check it?

[PhieF]

@licaon-kter 0.25.1 should be ok !

[licaon-kter]

@PhieF well #20 😭

[licaon-kter]

0.25.1 still connects to qn.phie.ovh on first start without pressing "say hi" :(

[PhieF]

@licaon-kter ok... this is not supposed to happen

when you install the app version, is it really 0.25.1 ?

[licaon-kter]

https://f-droid.org/packages/com.spisoft.quicknote/ see Build Metadata look at 0.25.1 commit: then decide yourself :)

[licaon-kter]

https://f-droid.org/packages/com.spisoft.quicknote/ see Build Metadata look at 0.25.1 commit: then decide yourself :)

[PhieF]

@licaon-kter I guess I've found it out, it was something done to retrieve other public nextcloud servers with Carnet in case someone else wanted to be on the list on the wizard, will remove that since it's not used at all, sorry for all of this