-
Notifications
You must be signed in to change notification settings - Fork 14
Add ids to UI and search for segments, flags, and experiments #2716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds ID-based search functionality for experiments, feature flags, and segments across the application. Users can now search and filter these entities by their UUID identifiers.
Key changes:
- Added
IDsearch key to enum definitions for experiments, feature flags, and segments - Implemented backend search logic with UUID validation for ID-based queries
- Updated frontend components to display IDs and enable ID-based filtering
- Modified filter options to include ID search capability in list views
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| types/src/Experiment/enums.ts | Added ID enum value to search key enums for experiments, segments, and flags |
| backend/packages/Upgrade/src/api/services/SegmentService.ts | Added UUID validation and ID search logic with null check handling |
| backend/packages/Upgrade/src/api/services/FeatureFlagService.ts | Implemented ID search with UUID validation returning empty string on invalid input |
| backend/packages/Upgrade/src/api/services/ExperimentService.ts | Added ID search functionality with UUID validation |
| backend/packages/Upgrade/src/api/controllers/validators/*.ts | Updated validator enums to include ID search key |
| frontend components | Added ID display in detail views and ID filter option in list views |
| frontend/projects/upgrade/src/app/features/dashboard/home/components/experiment-list/experiment-list.component.ts | Added ID search logic to client-side filtering |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
backend/packages/Upgrade/src/api/services/FeatureFlagService.ts
Outdated
Show resolved
Hide resolved
...rade/src/app/features/dashboard/home/components/experiment-list/experiment-list.component.ts
Outdated
Show resolved
Hide resolved
...rade/src/app/features/dashboard/home/components/experiment-list/experiment-list.component.ts
Outdated
Show resolved
Hide resolved
danoswaltCL
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
No description provided.