-
Notifications
You must be signed in to change notification settings - Fork 14
Open
Labels
Description
Version where bug was found:
6.3.0
Describe the bug
In the newly designed UI, creating an experiment with the "TS Configurable" assignment algorithm returns a "400 Bad Request" error stating that the moocletPolicyParameters and rewardMetricKey properties are missing from the request body.
{
"httpCode": 400,
"name": "BadRequestError",
"message": "Invalid body, check 'errors' property for more info.",
"errors": [
{
"property": "moocletPolicyParameters",
"children": [],
"constraints": {
"isDefined": "moocletPolicyParameters should not be null or undefined"
}
},
{
"property": "rewardMetricKey",
"children": [],
"constraints": {
"isDefined": "rewardMetricKey should not be null or undefined"
}
}
]
}To Reproduce
- Switch to the
experiment-design-refreshbranch. - Go to the Experiments root page.
- Click "Add Experiment".
- Fill out the form and select "TS Configurable" as the assignment algorithm.
- Click "Create".
- Observe the "400 Bad Request" error from the
POST /api/experimentsresponse.
Expected behavior
When "TS Configurable" is selected as the assignment algorithm, the request body should include valid values for moocletPolicyParameters and rewardMetricKey so that the experiment can be created without errors.
Additional notes
It appears that the request body should also include the "queries": [] as well. For example:
{
...existing data,
"moocletPolicyParameters": {
"assignmentAlgorithm": "ts_configurable",
"prior": {
"failure": 1,
"success": 1
},
"batch_size": 1,
"max_rating": 1,
"min_rating": 0,
"uniform_threshold": 0,
"tspostdiff_thresh": 0,
"outcome_variable_name": "EXP_NAME_IN_ALL_CAPS_REWARD_VARIABLE"
},
"queries": [],
"rewardMetricKey": "EXP_NAME_IN_ALL_CAPS_REWARD"
}Metadata
Metadata
Assignees
Labels
Type
Projects
Status
Code Review