Conversation
|
git workflow will soon be modified for .net 4.7.1 support |
trying to setup .net framework
csFastFloat/Utils/Utils.cs
Outdated
| if (value >> 28 == 0) { n += 4; value <<= 4; } | ||
| if (value >> 30 == 0) { n += 2; value <<= 2; } | ||
| n -= (int) (value >> 31); | ||
| return n; |
There was a problem hiding this comment.
I did not validate this algorithm (I am going to trust you). It seems reasonable. It is not going to be fast, but that's fine.
There was a problem hiding this comment.
I would prefer to understand why the previous version wasn't working as it should... at least we've got a workaround for now.
There was a problem hiding this comment.
I would not waste a lot of time on it. If you are convinced that it is something important, just go with what works, and create an issue explaining your concerns. Someone might pick it up. If not, your solution is fine. I would absolutely release 2.0 with this new code of yours.
|
@CarlVerret Why did you remove the -0 tests? We do want to parse -0 to -0. The platform can do what it likes, but we should check that we do it properly, like .NET 5. See How does your programming language handle “minus zero” (-0.0)? |
|
Actually I moved it to another test thats doesn't depends on displayed value |
Good! |
trying to add xunit runner with nuget
another try
removing Nuget setup step
another try :|
trying a workaround
another try with 2 test steps (seen on git)
yet another try
trying to put back together in one test step
name of step.
3 participants
There's something I don't understand with Log2SoftwareFallback as it was pushed previously. I pushed a workaround for now. All test are passing.