Adjustments for iPad #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Carifio24
added
enhancement
Carifio24
force-pushed
the
aspect-ratio
branch
from
df2580c to
7688162
Compare
…perly allow rotation.
…'t appear on an iPad.
…setting up frame boundaries.
…ell table cell buttons.
Carifio24
force-pushed
the
aspect-ratio
branch
from
76b7461 to
a39a24e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds iPad as a targeted device family and makes some adjustments to some pieces of the app layout to accommodate the largest screen size.
Ultimately I'd like to have it set up so that iPads get a master/detail layout while phones get the fullscreen table/slide-out spell window, like in the Android version. That's a more involved update that can wait until later, but this is still a marked improvement over the current state of things - currently, on an iPad, the app window has the aspect ratio of a phone.