Network multiplayer optimization (UI improvements)#9671
Open
MostCromulent wants to merge 3 commits intoCard-Forge:masterfrom
Open
Network multiplayer optimization (UI improvements)#9671MostCromulent wants to merge 3 commits intoCard-Forge:masterfrom
MostCromulent wants to merge 3 commits intoCard-Forge:masterfrom
Conversation
Improves user experience during network games: - Waiting timer shows player name and elapsed time (CMatchUI, InputLockUI) - Connection errors display detailed messages instead of generic failure - Adds CONN_ERROR_PREFIX constant for structured error handling - New localization strings for waiting and error messages UI-only changes, no game logic or delta sync functionality. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Use GameView data only in findWaitingForPlayerName() to work on both host and client (fixes null Game on network clients) - Add findPriorityPlayer() using PlayerView.getHasPriority() - Use localized string prefixes in isWaitingMessage() instead of hardcoded English strings - Add volatile to timer fields for thread safety Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
tool4ever
reviewed
Feb 5, 2026
| if (ixCall != iCall.get() || !isActive()) { | ||
| return; | ||
| } | ||
| FThreads.invokeInEdtLater(showMessageFromEdt); |
Contributor
There was a problem hiding this comment.
when is this relevant in netplay? somehow I never reached a breakpoint here... 🤔
I don't understand why there should be two timer systems:
If one input isn't enough, then why isn't it only handled in AbstractGuiGame instead so it works for mobile too?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
THIS PR HAS BEEN SPLIT FROM #9642.
Dependency
This branch is has been refactored to be fully independent from other features in #9642.
Features
Waiting timer and connection error improvements for network games:
timeout, no route to host)
Files Changed
CMatchUI.javaInputLockUI.javaNetConnectUtil.javaCSubmenuOnlineLobby.javaCONN_ERROR_PREFIXfor detailed error displayOnlineLobbyScreen.javaCONN_ERROR_PREFIXfor detailed error displayForgeConstants.javaCONN_ERROR_PREFIXconstanten-US.properties