Tie equipment loadouts to active deck#9599
Open
vanja-ivancevic wants to merge 2 commits intoCard-Forge:masterfrom
Open
Tie equipment loadouts to active deck#9599vanja-ivancevic wants to merge 2 commits intoCard-Forge:masterfrom
vanja-ivancevic wants to merge 2 commits intoCard-Forge:masterfrom
Conversation
Equipment is now automatically saved/restored when switching decks. Each deck remembers its own equipment configuration. - Add deckLoadouts HashMap to store per-deck equipment - Save/restore loadouts on deck switch in setSelectedDeckSlot() - Persist loadouts in save/load methods - Backward compatible with existing saves
vanja-ivancevic
force-pushed
the
feature/deck-equipment-loadouts
branch
from
f0b8cad to
e2e7781
Compare
Jetz72
added
Enhancement
Contributor
|
Seems like the kind of feature that should have to be enabled by a setting. There are users who keep 10+ decks, and if one of those people gets a better set of boots, it'll be a bit annoying having to go through and update the loadout for each of them. Having it default to off would also ensure the user understands that equipment is now tied to their active deck. Otherwise I suspect we'd encounter plenty of users that load up a game, switch decks, wander into battle without realizing all their equipment fell off, then file a bug report because they don't understand why it happened. |
Contributor
Author
|
Great point! I will update it as a setting, default "off". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Works well so far in testing.