Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Data Commons as iframe into Superset GUI #4

Open
dlworldpeace opened this issue May 4, 2022 · 2 comments
Open

Add Data Commons as iframe into Superset GUI #4

dlworldpeace opened this issue May 4, 2022 · 2 comments
Assignees
@MindyGaoo

Comments

@dlworldpeace
Copy link

dlworldpeace commented May 4, 2022 •
edited
Loading

Problem faced
GUI user cannot use the frontend to search datasets in Data Commons.

Solution proposed
Add a new page under Data header called Data Commons that is using iframe to show data commons tool page
Let's make a PR to merge into apache branch and ensure master branch is able to merge into apache branch as well.

Alternative solutions
Create a new page with a list of our common datasets, including Data Common as a link in this page.
@MindyGaoo MindyGaoo mentioned this issue May 15, 2022
Merged
@MindyGaoo
Copy link
Collaborator

solved with 9792068, 27ae0c4,d218cd350cee448b65689fe5b201f442ae9b4c38, time used: ~10hrs

@jasonvank
Copy link
Collaborator

#5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MindyGaoo MindyGaoo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jasonvank @dlworldpeace @MindyGaoo