Skip to content

Commit

Permalink
clear code, modify settings
Browse files Browse the repository at this point in the history
  • Loading branch information
MindyGaoo committed May 14, 2022
1 parent 27ae0c4 commit 9792068
Show file tree
Hide file tree
Showing 6 changed files with 13 additions and 32 deletions.
7 changes: 7 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -110,3 +110,10 @@ messages.mo
docker/requirements-local.txt

cache/


a/
python3/
setup/
virtualenv/
/#/
12 changes: 1 addition & 11 deletions superset-frontend/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion superset-frontend/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
],
"scripts": {
"_lint": "eslint --ignore-path=.eslintignore --ext .js,.jsx,.ts,tsx .",
"_prettier": "prettier './({src,spec,cypress-base,plugins,packages,.storybook}/**/*{.js,.jsx,.ts,.tsx,.css,.less,.scss,.sass}|package.json)'",
"_prettier": "",
"build": "cross-env NODE_OPTIONS=--max_old_space_size=8192 NODE_ENV=production BABEL_ENV=\"${BABEL_ENV:=production}\" webpack --mode=production --color",
"build-dev": "cross-env NODE_OPTIONS=--max_old_space_size=8192 NODE_ENV=development webpack --mode=development --color",
"build-instrumented": "cross-env NODE_ENV=production BABEL_ENV=instrumented webpack --mode=production --color",
Expand Down
18 changes: 0 additions & 18 deletions superset-frontend/src/views/components/Menu.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -332,27 +332,9 @@ export function Menu({

// transform the menu data to reorganize components
export default function MenuWrapper({ data, ...rest }: MenuProps) {
// data.menu[3].push({
// name: 'DataCommons',
// icon: 'fa-database',
// label: 'Data Commons',
// url: '/datacommons',
// });
// data.menu.forEach(function (arrayItem, index) {
// if (arrayItem.name === 'Data') {
// data.menu[index].push({
// name: 'DataCommons',
// icon: 'fa-database',
// label: 'Data Commons',
// url: '/datacommons',
// });
// }
// });
console.log('data', data.menu);
const newMenuData = {
...data,
};
console.log('newMenuData', newMenuData);
// Menu items that should go into settings dropdown
const settingsMenus = {
Security: true,
Expand Down
4 changes: 2 additions & 2 deletions superset-frontend/webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -221,10 +221,10 @@ const config = {
assetFilter(assetFilename) {
// don't throw size limit warning on geojson and font files
return !/\.(map|geojson|woff2)$/.test(assetFilename);
},
},
hints: false,
maxEntrypointSize: 512000,
maxAssetSize: 512000
maxAssetSize: 512000,
},
optimization: {
sideEffects: true,
Expand Down
2 changes: 2 additions & 0 deletions superset-websocket/.prettierignore
Original file line number Diff line number Diff line change
Expand Up @@ -22,3 +22,5 @@ coverage
.prettierrc.json
*.md
*.json
*.jsx
*.tsx

0 comments on commit 9792068

Please sign in to comment.