AGTC-155 Add intuitive images for game actions to increase accessibility #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethbern
requested changes
Mar 28, 2025
There was a problem hiding this comment.
Is there another icon we could use for this, I don't think it offers any affordances so its not clear what it does unless you already know. Maybe something like the send icon they have in discord/slack
|
For the send button, if we create an icon for each role, the button image could be the manager icon to "send to manager". For the clear cup button, maybe an undo icon would work. Everything else looks good. |
sethbern
approved these changes
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only action I did not replace with an image was clear cup - I think clearing the cup to be able to change colors is weird and I am not sure how to accurately describe this with an image. Please give suggestions.