[AGTC-178] Fix backend response sending/receiving blocking #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuo20482
reviewed
Mar 27, 2025
| """Receive a message or None if empty.""" | ||
| try: | ||
| return self._recv.get_nowait() | ||
| except queue.Empty: | ||
| return None | ||
|
|
||
| def recv(self) -> T: |
There was a problem hiding this comment.
While I was testing the changes, I found that this section was the only change required to fix the problem. Unless there's a good reason to include the other changes, I propose we just do this
Previous config would hang on configuration, and would not allow app to start.
jonathan-d-zhang
force-pushed
the
send-recv-two-tasks
branch
from
1034a9b to
9407c7d
Compare
jonathan-d-zhang
force-pushed
the
send-recv-two-tasks
branch
from
9407c7d to
b2858a4
Compare
Andriy-Luchko
approved these changes
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split recv and send functions into two tasks to run async.