SW-201 Fix CoreData Persistence #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed/removed an initialization to make sure the NSPersistentObject is correctly called and the same one is used throughout the app
AdamRa97
requested review from
SlowMiata,
tdotbui,
parchea,
DanielEap,
dillon09776 and
jtstanczak7
AdamRa97
changed the title
DanielEap
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed unnecessary inMemory lines from Persistence.swift, also changed/removed an initialization to make sure the NSPersistentObject is correctly called and the same one is used throughout the app
Fixed the issue of the CoreData entities/attributes not saving correctly when closing and reopening app.
The user should now be able to see the past workouts even after closing out of the app.