Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added screenshot functionality so that user can save an image of thei… #146

Merged
merged 3 commits into from
Apr 17, 2024
Merged

Added screenshot functionality so that user can save an image of thei… #146

merged 3 commits into from
Apr 17, 2024

Conversation

AdamRa97
Copy link
Contributor

…r profile to their Photo Library to share with friends

@AdamRa97
Added screenshot functionality so that user can save an image of thei…
4ac0f3e 
…r profile to their Photo Library to share with friends
DanielEap
DanielEap approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@DanielEap DanielEap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saw the demo, looks great. Look forward to getting the share feature integrated

SlowMiata
SlowMiata approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@SlowMiata SlowMiata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it and it works

jtstanczak7
jtstanczak7 approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@jtstanczak7 jtstanczak7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

SlowMiata
SlowMiata reviewed Apr 17, 2024
View reviewed changes
Copy link
Contributor

@SlowMiata SlowMiata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just added code to crop the image

tdotbui
tdotbui approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@tdotbui tdotbui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Camera screenshot functionality is working as tested. Might look into screenshottable views to get rid of the the navbar.

@AdamRa97 AdamRa97 merged commit 51be35a into testing Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SlowMiata SlowMiata SlowMiata approved these changes

@jtstanczak7 jtstanczak7 jtstanczak7 approved these changes

@DanielEap DanielEap DanielEap approved these changes

@tdotbui tdotbui tdotbui approved these changes

@parchea parchea Awaiting requested review from parchea

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AdamRa97 @SlowMiata @tdotbui @DanielEap @jtstanczak7