Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate overscan on Kiosk #130

Merged
merged 4 commits into from
Apr 29, 2024
Merged

Eliminate overscan on Kiosk #130

merged 4 commits into from
Apr 29, 2024

Conversation

Snarr
Copy link
Contributor

@Snarr Snarr commented Apr 29, 2024

Changes

1. Added config.txt and cmdline.txt to boot/firmware

This will move our config files into the proper location for flashing an image to the Pi.

2. Comment out potential lines causing overscan black borders

Removed certain lines in config.txt that had potential to add black borders.

3. Add flags to Chromium Browser execution to change window size, position, and scale

These turned out to the be the true cause of our overscan/black border issues in kiosk mode.

Tickets Covered:

Copy link
Contributor

@gummyfrog gummyfrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Knew it all along

Copy link
Contributor

@tuk05348 tuk05348 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tuk05348 tuk05348 merged commit f98d1d3 into main Apr 29, 2024
3 checks passed
@Snarr Snarr deleted the BP-XXX-Install-Config-Changes branch May 2, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants