feat: allow bypassing/streamlining of login using browser profiles #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bancey
changed the title
ewingjm
requested changes
Jun 15, 2021
...s/src/Capgemini.PowerApps.SpecFlowBindings/Configuration/BrowserOptionsWithProfileSupport.cs
Outdated
Show resolved
Hide resolved
...s/src/Capgemini.PowerApps.SpecFlowBindings/Configuration/BrowserOptionsWithProfileSupport.cs
Show resolved
Hide resolved
bindings/src/Capgemini.PowerApps.SpecFlowBindings/PowerAppsStepDefiner.cs
Outdated
Show resolved
Hide resolved
bindings/src/Capgemini.PowerApps.SpecFlowBindings/PowerAppsStepDefiner.cs
Outdated
Show resolved
Hide resolved
bindings/src/Capgemini.PowerApps.SpecFlowBindings/PowerAppsStepDefiner.cs
Outdated
Show resolved
Hide resolved
bindings/src/Capgemini.PowerApps.SpecFlowBindings/PowerAppsStepDefiner.cs
Outdated
Show resolved
Hide resolved
bindings/src/Capgemini.PowerApps.SpecFlowBindings/PowerAppsStepDefiner.cs
Outdated
Show resolved
Hide resolved
bindings/src/Capgemini.PowerApps.SpecFlowBindings/PowerAppsStepDefiner.cs
Outdated
Show resolved
Hide resolved
ewingjm
reviewed
Jun 16, 2021
bindings/src/Capgemini.PowerApps.SpecFlowBindings/PowerAppsStepDefiner.cs
Outdated
Show resolved
Hide resolved
ewingjm
previously approved these changes
Jun 16, 2021
ewingjm
reviewed
Jun 16, 2021
bindings/src/Capgemini.PowerApps.SpecFlowBindings/Steps/LoginSteps.cs
Outdated
Show resolved
Hide resolved
added 10 commits
June 16, 2021 19:36
…river is actuall disposed
currentProfileDirectory wasn't always being set to null when Quit() was called before xrmApp was instantiated.
…-specflow-bindings into AB/bypass-login
|
Kudos, SonarCloud Quality Gate passed! |
ewingjm
approved these changes
Jun 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Addresses #86 by using chrome/firefox user profiles to store history/cache enabling subsequent test cases to run faster.
Approach
If the use of profiles is enabled via the yml config, it will create a profile directory for each of the defined users, this is then passed as an argument to the underlying driver.
There is currently an issue with EasyRepro with the "Pick an Account" Microsoft login dialog which means the Login functionality is currently broken. A helper method has been added to the Login steps to clear these from the dialog allowing the OOTB login functionality to be used. This can be removed when microsoft/EasyRepro#1143 is merged.