Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow driversPath to be environment variable #63

Merged
merged 1 commit into from
Jan 26, 2021

Conversation

LukeBenting
Copy link
Contributor

Purpose

Resolves #49. As documented here, Microsoft recommend that you use the Web Drivers that are preinstalled on Microsoft Hosted agents, this avoids a version mismatch between Chrome and ChromeDriver. Prior to this commit, there was no way to make use of these environment variables.

Approach

The BrowserOptions for EasyRepro allows for a driversPath variable to be provided. This commit adds logic to allow for this to be an Environment Variable. So the environment variables stated in the Microsoft Docs can be supplied. To run the ui tests for this repo locally, where the driver .exe is outputted to bin, simply create an environment variable for 'ChromeWebDriver' with a value of '.\'.

TODOs

  • Automated test coverage for new code
  • Documentation updated (if required)
  • Build and tests successful

@sonarcloud
Copy link

sonarcloud bot commented Jan 26, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@ewingjm ewingjm merged commit 9fc6c46 into master Jan 26, 2021
@ewingjm ewingjm deleted the feature/read-driverspath_from_env_var branch January 26, 2021 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set driver path based on Azure Pipelines driver environment variables
2 participants