Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 2021 release wave 2 #119

Merged
merged 43 commits into from
Aug 4, 2022
Merged

feat: 2021 release wave 2 #119

merged 43 commits into from
Aug 4, 2022

Conversation

ewingjm
Copy link
Member

@ewingjm ewingjm commented Jul 4, 2022

Purpose

This branch resolves a number of issues that were introduced with release wave 2 2021.

Approach

Updates EasyRepro dependencies and fixes internal selectors.

TODOs

  • Automated test coverage for new code
  • Documentation updated (if required)
  • Build and tests successful

ewingjm and others added 13 commits October 19, 2021 10:13
The CI environment has been disabled due to lack of space in the tenant. However, this pre-release version is critical.
Allows test data cleanup to be  toggled by setting `deleteTestData` to `false` in the config file. Not specifying this will continue to exhibit the existing behaviour.
Microsoft update to the PPBT caused the provision environment step to not output the environment URL correctly.
…ting. Issues will be raised with EasyRepro for further investigation.
leroy-douglas and others added 5 commits July 28, 2022 09:15
* fix: refreshes the app access token [wip]

* fix: added appUserRecordRepository to the browser window object to ensure that it is possible to call appUserRecordRepository.updateAccessToken(accessToken) at a later time

* fix: refactored AccessToken

Co-authored-by: Tom Ashworth <tom.ashworth@capgemini.com> and Leroy Douglas <leroy.douglas@capgemini.com>
@tdashworth tdashworth marked this pull request as ready for review August 2, 2022 11:22
Copy link
Member Author

@ewingjm ewingjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, we'll revert the changes made regarding token expiry as we don't actually believe this to be an issue.

@tdashworth
Copy link
Contributor

Manual validation requested
Please perform any checks required on https://sfb-pr-7876.crm11.dynamics.com/ then approve https://dev.azure.com/capgeminiuk/GitHub%20Support/_build/results?buildId=7876.

tdashworth
tdashworth previously approved these changes Aug 3, 2022
leroy-douglas
leroy-douglas previously approved these changes Aug 3, 2022
@ewingjm ewingjm dismissed stale reviews from leroy-douglas and tdashworth via bf9e56a August 3, 2022 16:27
@tdashworth
Copy link
Contributor

Manual validation requested
Please perform any checks required on https://sfb-pr-7879.crm11.dynamics.com/ then approve https://dev.azure.com/capgeminiuk/GitHub%20Support/_build/results?buildId=7879.

@sonarcloud
Copy link

sonarcloud bot commented Aug 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@tdashworth
Copy link
Contributor

Manual validation requested
Please perform any checks required on https://sfb-pr-7880.crm11.dynamics.com/ then approve https://dev.azure.com/capgeminiuk/GitHub%20Support/_build/results?buildId=7880.

@tdashworth tdashworth self-requested a review August 4, 2022 12:39
@ewingjm ewingjm merged commit dcc353e into master Aug 4, 2022
@ewingjm ewingjm deleted the feat/2021-release-wave-2 branch August 4, 2022 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants