Skip to content

Fix: CharacterCount component not resetting red error text after valid input #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daniele-zurico merged 3 commits into from
Jun 16, 2023
Merged

Fix: CharacterCount component not resetting red error text after valid input #471

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c703827
fix: charactercount component not resetting red error text after vali…
May 5, 2023
73646a4
Merge branch 'release/0.8' into feature/463-character-count-error-bug
byohannes Jun 14, 2023
7de37a3
fix: the character count component error message returns to default a…
byohannes Jun 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/characterCount/CharacterCount.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,8 @@ export const CharacterCount = forwardRef(
const overThreshold = isOverThreshold(value);

setShowMessage(overThreshold || !threshold);
if (remaining < 0) setOverLimitBy(-remaining);
if (remaining <= 0) setOverLimitBy(-remaining);
if (remaining > 0) setOverLimitBy(0);
setRemainingCount(remaining);
};

Expand Down
15 changes: 15 additions & 0 deletions src/characterCount/__tests__/CharacterCount.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ const DummyResetCharacterCountComponent = () => {
rows={5}
cols={50}
ref={textRef}
messageErrorClassName="error-class-name"
/>
<button onClick={() => textRef.current.reset()}>Cancel</button>
</form>
Expand Down Expand Up @@ -131,6 +132,20 @@ describe('CharacterCount with character limit', () => {
expect(error).not.toBeInTheDocument();
});

it('should assign error class for error message and remove class if user backspaces to correct input', async () => {
const user = userEvent.setup();
const { container } = render(<DummyResetCharacterCountComponent />);
const textarea = screen.getByRole('textbox');

await user.type(textarea, 'more than 15 chars');
expect(container.querySelector('.error-class-name')).toBeInTheDocument();

await user.type(textarea, '{backspace}{backspace}{backspace}');
expect(
container.querySelector('.error-class-name')
).not.toBeInTheDocument();
});

it('should display error message when displayError is true', () => {
render(
<CharacterCount
Expand Down