Skip to content

Conversation

@SergioBanderaGarcia
Copy link
Collaborator

You can put string or number as value in the button.
image

@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (7a69ae0) compared to base (df663fe).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #342   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           43        43           
  Lines          999       999           
  Branches       384       384           
=========================================
  Hits           999       999           
Impacted Files Coverage Δ
src/button/Button.tsx 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@SergioBanderaGarcia SergioBanderaGarcia requested review from alexwbbr and daniele-zurico and removed request for alexwbbr September 16, 2022 13:08
@daniele-zurico
Copy link
Contributor

hi @SergioBanderaGarcia thanks for your PR... it looks pretty good only thing missed is the documentation in storybook. Can you please add the value attribute in the following files:

  • /stories/Button/Documentation.stories.mdx
  • /stories/liveEdit/ButtonLive.tsx

you can run the command yarn storybook to see the output in your browser

@SergioBanderaGarcia
Copy link
Collaborator Author

done, i hope it's ok, because it's my first time contributing and I don't know how to do it exactly :)

@daniele-zurico daniele-zurico merged commit 94d80f6 into main Sep 20, 2022
@daniele-zurico daniele-zurico deleted the feature/button-value branch March 14, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants