Skip to content

Conversation

@alexwbbr
Copy link
Collaborator

@alexwbbr alexwbbr commented Jul 15, 2022

Updates the button component to have a name property

#314

@alexwbbr alexwbbr added this to the 0.5 milestone Jul 15, 2022
@alexwbbr alexwbbr requested a review from daniele-zurico July 15, 2022 10:50
@alexwbbr alexwbbr linked an issue Jul 15, 2022 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Jul 15, 2022

Codecov Report

Merging #316 (d611202) into release/0.5 (fa5c049) will not change coverage.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##           release/0.5      #316   +/-   ##
=============================================
  Coverage       100.00%   100.00%           
=============================================
  Files               42        42           
  Lines              910       910           
  Branches           334       334           
=============================================
  Hits               910       910           
Impacted Files Coverage Δ
src/button/Button.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa5c049...d611202. Read the comment docs.

@daniele-zurico
Copy link
Contributor

hi @alexwbbr thanks for your PR can you please also update the live version of documentation please?

@alexwbbr alexwbbr merged commit c8ae4d6 into release/0.5 Jul 15, 2022
@daniele-zurico daniele-zurico deleted the feature/button-name branch March 14, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Button doesn't allow to pass property name

4 participants