Skip to content

Conversation

@Ibabalola
Copy link
Contributor

@Ibabalola Ibabalola commented Jun 23, 2022

  • updated storybook packages to resolve security vulnerabilities
  • updated react-scripts
  • update react-router-dom
  • update fortawesome
  • update node-sass

@daniele-zurico
Copy link
Contributor

daniele-zurico commented Jun 23, 2022

why you don't try to do a full bump of all the packages?
On the other side most of the criticality are in the example/package.json

@Ibabalola Ibabalola changed the title fix: resolving storybook outdated packages fix: resolving packages Jun 23, 2022
@Ibabalola
Copy link
Contributor Author

Ibabalola commented Jun 23, 2022

@daniele-zurico I've attempted to do a full bump of all packages however doing so breaks example

@codecov-commenter
Copy link

codecov-commenter commented Jun 23, 2022

Codecov Report

Merging #295 (7345337) into release/0.5 (79bd53c) will not change coverage.
The diff coverage is n/a.

❗ Current head 7345337 differs from pull request most recent head de3d4c8. Consider uploading reports for the commit de3d4c8 to get more accurate results

@@              Coverage Diff              @@
##           release/0.5      #295   +/-   ##
=============================================
  Coverage       100.00%   100.00%           
=============================================
  Files               42        42           
  Lines              909       909           
  Branches           333       333           
=============================================
  Hits               909       909           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79bd53c...de3d4c8. Read the comment docs.

@Ibabalola Ibabalola linked an issue Jun 24, 2022 that may be closed by this pull request
@Ibabalola Ibabalola merged commit e2cacd1 into release/0.5 Jun 24, 2022
@daniele-zurico daniele-zurico deleted the enchancement/288 branch March 14, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Review dependabot alerts

4 participants