Skip to content

Conversation

@ellietms
Copy link
Contributor

please let me know if you think it is not correct, as this is my first PR 🎉
Thanks a lot.

@daniele-zurico daniele-zurico changed the base branch from main to release/0.5 June 23, 2022 10:03
@Ibabalola
Copy link
Contributor

Hi @ellietms - we will also need to update the corresponding .mdx stories for the button component to demostrate how this new property works, please have a look at the stories/Button/ folder

@daniele-zurico
Copy link
Contributor

Hi @ellietms - we will also need to update the corresponding .mdx stories for the button component to demostrate how this new property works, please have a look at the stories/Button/ folder

I suggest to change only the live version?

@ellietms
Copy link
Contributor Author

Hi @ellietms - we will also need to update the corresponding .mdx stories for the button component to demostrate how this new property works, please have a look at the stories/Button/ folder

I have updated my code please review it, Thanks @Ibabalola @daniele-zurico

@daniele-zurico daniele-zurico self-requested a review July 6, 2022 10:42
@ellietms ellietms merged commit 5c859a2 into release/0.5 Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants