tweak: adjust disabled colors for gray variant #978
Conversation
WalkthroughMinor UI text and styling adjustments: CustomDomain component copy and status pill color/text updated; Button gray variant’s disabled-state classes tweaked (border and text colors). No logic or control-flow changes; no exported API changes. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (2)
packages/ui/src/components/Button.tsx (1)
26-26: Confirm intent for darker disabled text on gray variant.
disabled:text-gray-11is notably darker than other variants (oftengray-9). If this is a deliberate spec change, all good; otherwise consider aligning for consistency or documenting in the DS.apps/web/app/(org)/dashboard/settings/organization/components/CustomDomain.tsx (1)
103-105: Verify contrast after changing to text-gray-8.On
bg-gray-2,text-gray-8may be low-contrast. Please confirm it meets our token/WCAG guidance; bump togray-9if needed.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
apps/web/app/(org)/dashboard/settings/organization/components/CustomDomain.tsx(1 hunks)packages/ui/src/components/Button.tsx(1 hunks)
🧰 Additional context used
📓 Path-based instructions (3)
apps/web/**/*.{ts,tsx}
📄 CodeRabbit inference engine (CLAUDE.md)
apps/web/**/*.{ts,tsx}: Use TanStack Query v5 for client-side server state and data fetching in the web app
Mutations should call Server Actions and perform precise cache updates with setQueryData/setQueriesData, avoiding broad invalidations
Prefer Server Components for initial data and pass initialData to client components for React Query hydration
Files:
apps/web/app/(org)/dashboard/settings/organization/components/CustomDomain.tsx
{apps/web,packages/ui}/**/*.{ts,tsx}
📄 CodeRabbit inference engine (CLAUDE.md)
{apps/web,packages/ui}/**/*.{ts,tsx}: Use Tailwind CSS exclusively for styling in the web app and shared React UI components
Component naming: React components in PascalCase; hooks in camelCase starting with 'use'
Files:
apps/web/app/(org)/dashboard/settings/organization/components/CustomDomain.tsxpackages/ui/src/components/Button.tsx
**/*.{ts,tsx}
📄 CodeRabbit inference engine (CLAUDE.md)
Use strict TypeScript and avoid any; prefer shared types from packages
Files:
apps/web/app/(org)/dashboard/settings/organization/components/CustomDomain.tsxpackages/ui/src/components/Button.tsx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Build Desktop (aarch64-apple-darwin, macos-latest)
- GitHub Check: Build Desktop (x86_64-pc-windows-msvc, windows-latest)
- GitHub Check: Analyze (rust)
🔇 Additional comments (1)
packages/ui/src/components/Button.tsx (1)
26-26: Good call adding a disabled border color.
disabled:border-gray-7improves affordance in the disabled state. Looks consistent with the bg shift todisabled:bg-gray-8.
| </h1> | ||
| <p className="w-full text-sm text-gray-10"> | ||
| Set up a custom domain for your organization's shared caps. | ||
| Setup a custom domain for your organization's shared caps. |
There was a problem hiding this comment.
Fix grammar: use “Set up” (verb), not “Setup”.
Apply:
- Setup a custom domain for your organization's shared caps.
+ Set up a custom domain for your organization's shared caps.📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| Setup a custom domain for your organization's shared caps. | |
| Set up a custom domain for your organization's shared caps. |
🤖 Prompt for AI Agents
In
apps/web/app/(org)/dashboard/settings/organization/components/CustomDomain.tsx
around line 97, the displayed sentence uses the noun "Setup" but should use the
verb phrase "Set up"; update the string literal to "Set up a custom domain for
your organization's shared caps." so the grammar is correct and rebuild to
verify the UI text updates.
| <p className="text-[13px] text-gray-8"> | ||
| {orgCustomDomain || "No custom domain has been setup"} | ||
| </p> |
There was a problem hiding this comment.
Fix grammar in fallback text.
Use “set up” (verb) and a period.
- <p className="text-[13px] text-gray-8">
- {orgCustomDomain || "No custom domain has been setup"}
+ <p className="text-[13px] text-gray-8">
+ {orgCustomDomain || "No custom domain has been set up."}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| <p className="text-[13px] text-gray-8"> | |
| {orgCustomDomain || "No custom domain has been setup"} | |
| </p> | |
| <p className="text-[13px] text-gray-8"> | |
| {orgCustomDomain || "No custom domain has been set up."} | |
| </p> |
🤖 Prompt for AI Agents
In
apps/web/app/(org)/dashboard/settings/organization/components/CustomDomain.tsx
around lines 103 to 105, the fallback text "No custom domain has been setup" has
incorrect grammar and missing punctuation; change the displayed string to use
the verb form and add a period, e.g., "No custom domain has been set up." so the
JSX renders the corrected sentence.
Summary by CodeRabbit