fix: duplicate shortcut

[ameer2468]

This PR: removes duplicate shortcut.

• Removed toggling Aspect Ratio menu shortcut.
• Also removed shortcut to toggle Crop dialog.

Don't think these are critical enough actions unless we get enough feedback on this.

Summary by CodeRabbit

• Refactor
  • Removed keyboard shortcuts: “A” for Aspect Ratio selector and “C” for opening Crop.
• Style
  • Removed on-screen keyboard shortcut hints for Aspect Ratio and Crop buttons.
  • Updated tooltip label from “Split” to “Toggle Split.”

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

This change removes keyboard shortcut bindings and on-screen kbd hints for the editor’s Aspect Ratio selector and Crop action, and adjusts one tooltip label. All other state management, rendering, and behaviors remain unchanged.

Changes

Cohort / File(s)	Summary of Changes
Editor Aspect Ratio shortcut removal apps/desktop/src/routes/editor/AspectRatioSelect.tsx	Deleted global keydown handler and its import that toggled the dropdown on "A". Removed Tooltip kbd hint (from kbd=["A"] to plain content). No changes to open/value/options logic.
Player shortcuts and tooltip updates apps/desktop/src/routes/editor/Player.tsx	Removed "C" shortcut binding for cropDialogHandler and removed kbd hint on Crop button. Updated Split button tooltip text from "Split" to "Toggle Split". No public API changes.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor User
  participant Document
  participant AspectRatioSelect
  participant Player

  rect rgb(245,248,255)
  note right of User: Before (shortcuts enabled)
  User->>Document: keydown "A"
  Document->>AspectRatioSelect: toggle dropdown
  User->>Document: keydown "C"
  Document->>Player: invoke cropDialogHandler
  end

  rect rgb(243,250,245)
  note right of User: After (shortcuts removed)
  User->>Document: keydown "A"/"C"
  Document--xAspectRatioSelect: no handler
  Document--xPlayer: no handler
  note over AspectRatioSelect,Player: UI tooltips show without kbd hints
  end

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• new: editor shortcuts #936 — Earlier PR that added these keyboard shortcut bindings and Tooltip kbd hints; this PR removes/reverses those changes in the same areas.

Poem

A tap of A, a click of C—now gone, what keys once knew,
I twitch my ears and nudge the UI: mouse leads us through.
Split now says “Toggle Split,” concise and clear to see,
No phantom keys beneath the tips—just simple harmony.
Hop, hop—clean crops, no shortcuts chasing me. 🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between afb7e0f and ed2b611.

📒 Files selected for processing (2)

• apps/desktop/src/routes/editor/AspectRatioSelect.tsx (1 hunks)
• apps/desktop/src/routes/editor/Player.tsx (1 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix-duplicate-shortcut

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.