Refactor Pro subscription check for third-party support

[richiemcilroy]

Moved the check for thirdPartyStripeSubscriptionId into the userIsPro utility function, ensuring consistent logic for determining Pro status. Removed redundant check from the API route.

Summary by CodeRabbit

• New Features

  • Recognizes third‑party subscriptions as Pro, ensuring eligible users get immediate access.
  • Expands supported subscription statuses to include “complete” and “paid,” improving coverage of billing scenarios.

• Bug Fixes

  • Corrects Pro status detection by relying on verified subscription data, reducing false positives from legacy fields.
  • Improves synchronization with billing records to more accurately reflect active subscriptions for users without an existing subscription ID.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The API route removed an auto-subscribe path based on third-party IDs. Subscription status now depends on userIsPro and Stripe checks. The utils userIsPro gained support for third-party subscription IDs and broadened accepted Stripe statuses to include complete and paid.

Changes

Cohort / File(s)	Summary
API subscription flow apps/web/app/api/desktop/[...route]/root.ts	Removed automatic isSubscribed=true when user.thirdPartyStripeSubscriptionId is present. Retained Stripe-based fetch/update when needed. Now relies on userIsPro(user) and Stripe data for subscription determination.
Utils: pro status evaluation packages/utils/src/constants/plans.ts	Updated userIsPro signature to accept thirdPartyStripeSubscriptionId. Returns true if this field exists. Expanded valid statuses to include complete and paid alongside active and trialing.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant Client
  participant API Route
  participant Plans.userIsPro
  participant Stripe
  participant DB

  Client->>API Route: Request (needs subscription)
  API Route->>Plans.userIsPro: Evaluate(user)
  alt userIsPro true (third-party ID or valid status)
    Plans.userIsPro-->>API Route: true
    API Route-->>Client: Proceed as subscribed
  else userIsPro false
    Plans.userIsPro-->>API Route: false
    alt No stripeSubscriptionId AND has stripeCustomerId
      API Route->>Stripe: List subscriptions
      Stripe-->>API Route: Active subscription?
      alt Found active (active/trialing/complete/paid)
        API Route->>DB: Update user subscription info
        API Route-->>Client: Proceed as subscribed
      else None found
        API Route-->>Client: Not subscribed
      end
    else No Stripe lookup path
      API Route-->>Client: Not subscribed
    end
  end

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Poem

I twitch my ears at flags that flip,
No secret switch, no hasty slip.
If Stripe says “paid,” I thump in cheer,
Third-party notes? I hold them dear.
Hoppity-checks, concise and true—
Subscriptions sorted, carrot-deux. 🥕🐇

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 3a0f58a and ea25ff2.

📒 Files selected for processing (2)

• apps/web/app/api/desktop/[...route]/root.ts (0 hunks)
• packages/utils/src/constants/plans.ts (1 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch sub-status-fix

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.