Skip to content

improvement: Hide Windows App Settings Group #954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ameer2468 merged 2 commits into from
Aug 26, 2025
Merged

improvement: Hide Windows App Settings Group #954

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
346e79b
shouldnt render the App settings group since they are for mac only
ameer2468 Aug 26, 2025
64c3ab8
formatting
ameer2468 Aug 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
186 changes: 97 additions & 89 deletions apps/desktop/src/routes/(window-chrome)/settings/general.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,7 @@ function Inner(props: { initialStore: GeneralSettingsStore | null }) {

type SettingsGroup = {
title: string;
os?: "macos" | "windows" | "linux";
titleStyling?: string;
items: SettingItem[];
};
Expand All @@ -190,6 +191,7 @@ function Inner(props: { initialStore: GeneralSettingsStore | null }) {
},
{
title: "App",
os: "macos",
items: [
{
label: "Hide dock icon",
Expand Down Expand Up @@ -383,100 +385,106 @@ function Inner(props: { initialStore: GeneralSettingsStore | null }) {

<For each={settingsGroups}>
{(group) => (
<div>
<h3
class={cx(
"mb-3 text-sm text-gray-12 w-fit",
group.titleStyling,
)}
>
{group.title}
</h3>
<div class="px-3 rounded-xl border divide-y divide-gray-3 border-gray-3 bg-gray-2">
<For each={group.items}>
{(item) => {
// Check OS compatibility
if (
item.type === "toggle" &&
item.os &&
item.os !== ostype
) {
return null;
}

if (item.type === "toggle") {
return (
<ToggleSetting
pro={group.title === "Cap Pro"}
label={item.label}
description={item.description}
value={item.value}
onChange={item.onChange}
/>
);
} else if (item.type === "select") {
<Show when={group.os === ostype || !group.os}>
<div>
<h3
class={cx(
"mb-3 text-sm text-gray-12 w-fit",
group.titleStyling,
)}
>
{group.title}
</h3>
<div class="px-3 rounded-xl border divide-y divide-gray-3 border-gray-3 bg-gray-2">
<For each={group.items}>
{(item) => {
// Check OS compatibility
if (
item.label === "Main window recording start behaviour"
) {
return renderRecordingSelect(
item.label,
item.description,
() => item.value,
item.onChange,
[
{ text: "Close", value: "close" },
{ text: "Minimise", value: "minimise" },
],
);
} else if (
item.label === "Studio recording finish behaviour"
) {
return renderRecordingSelect(
item.label,
item.description,
() => item.value,
item.onChange,
[
{ text: "Open editor", value: "openEditor" },
{ text: "Show in overlay", value: "showOverlay" },
],
);
} else if (item.label === "Recording countdown") {
return renderRecordingSelect(
item.label,
item.description,
() => item.value,
item.onChange,
[
{ text: "Off", value: 0 },
{ text: "3 seconds", value: 3 },
{ text: "5 seconds", value: 5 },
{ text: "10 seconds", value: 10 },
],
);
} else if (
item.label === "After deleting recording behaviour"
item.type === "toggle" &&
item.os &&
item.os !== ostype
) {
return renderRecordingSelect(
item.label,
item.description,
() => item.value,
item.onChange,
[
{ text: "Do Nothing", value: "doNothing" },
{
text: "Reopen Recording Window",
value: "reopenRecordingWindow",
},
],
return null;
}

if (item.type === "toggle") {
return (
<ToggleSetting
pro={group.title === "Cap Pro"}
label={item.label}
description={item.description}
value={item.value}
onChange={item.onChange}
/>
);
} else if (item.type === "select") {
if (
item.label ===
"Main window recording start behaviour"
) {
return renderRecordingSelect(
item.label,
item.description,
() => item.value,
item.onChange,
[
{ text: "Close", value: "close" },
{ text: "Minimise", value: "minimise" },
],
);
} else if (
item.label === "Studio recording finish behaviour"
) {
return renderRecordingSelect(
item.label,
item.description,
() => item.value,
item.onChange,
[
{ text: "Open editor", value: "openEditor" },
{
text: "Show in overlay",
value: "showOverlay",
},
],
);
} else if (item.label === "Recording countdown") {
return renderRecordingSelect(
item.label,
item.description,
() => item.value,
item.onChange,
[
{ text: "Off", value: 0 },
{ text: "3 seconds", value: 3 },
{ text: "5 seconds", value: 5 },
{ text: "10 seconds", value: 10 },
],
);
} else if (
item.label === "After deleting recording behaviour"
) {
return renderRecordingSelect(
item.label,
item.description,
() => item.value,
item.onChange,
[
{ text: "Do Nothing", value: "doNothing" },
{
text: "Reopen Recording Window",
value: "reopenRecordingWindow",
},
],
);
}
}
}
return null;
}}
</For>
return null;
}}
</For>
</div>
</div>
</div>
</Show>
)}
</For>

Expand Down
Loading