chore: handle res not ok

[ameer2468]

fetch only throws on network errors and not http status codes my bad.

Summary by CodeRabbit

• Bug Fixes

  • Prevented saving names with accidental leading/trailing spaces by trimming first and last names.
  • Improved validation when updating account name to avoid silent failures and surface clear error feedback if the update fails.

• New Features

  • More consistent formatting of profile names by normalizing optional fields (empty last name now handled gracefully).

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

Adds response validation to the name update mutation and normalizes payload by trimming first/last names and sending null for empty values.

Changes

Cohort / File(s)	Summary
Account settings mutation apps/web/app/(org)/dashboard/settings/account/Settings.tsx	- Capture fetch response and throw on non-OK status - Trim firstName/lastName; send null when empty - JSON body updated to reflect trimmed/null values; headers unchanged

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor User
  participant UI as Settings.tsx (Client)
  participant API as /api/account/name

  User->>UI: Submit name change
  UI->>API: POST { firstName, lastName } (trimmed/null)
  API-->>UI: HTTP 200 OK / error

  alt success
    UI-->>User: Show success / update state
  else error (non-OK response)
    UI->>UI: Throw Error("Failed to update name")
    UI-->>User: Show error message
  end

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• fix: remove last name requirement + redirection to onboarding bug #952: Also adjusts the name-update submission flow in the same Settings.tsx, including fetch/mutation handling and payload normalization.

Poem

I nibble bytes, I trim the names,
First and last, no trailing games.
If fields are empty—null they go,
And errors speak when servers say “no.”
Hop, commit, and off I run—
Cleaned-up forms, request well-done! 🐇✨

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 684c716 and 5473c2a.

📒 Files selected for processing (1)

• apps/web/app/(org)/dashboard/settings/account/Settings.tsx (1 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch handle-res-not-okay

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.