Camera preview fixes

[oscartbeaumont]

Users are running into a lot of race conditions in the setup and switching of camera and microphones so we are actorifying them to simplify the logic and avoid race conditions.

• Move renderer lifecycle to the window not the camera to fix Tauri errors
• Fix the camera preview randomly not intializing -> I think we have a race conditon on window.close() at the wrong time which is the root cause of all these issues.
• Shutdown the camera without streching
• Cleanup camera preview code
  • Delay surface.configure into the window event loop.
  • Ask Tauri for window size first thing and then parse that value down as the default. That way it's super unlikely the window can have been removed prior to it being used. Can we even set the default size in the window builder and pass that down??? This could allow us to remove the window.outer_size fallback thing which is kinda cringe.
  • I wonder if we need (CancellationToken, flume::Sender<T>) so we can propogate shutdown quickly from camera_feed into the CameraPreview.

methods on ref
Make recording await the camera being ready

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch camera-preview-fixes

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[oscartbeaumont]

TODO:

• Should we cleanup senders where stop_capturing is manually called???
• How to close camera preview when camera feed detaches
• Using native camera preview or not?
• Hook up RawCameraFrame from camera preview actor with camera actor
• Implement Render message handler
• Implement Reconfigure
• Properly cleanup camera preview from App on window close
• Set correct camera size and position on window builder.
• Propogate camera preview shutdown
• CameraPreview::save
• CameraPreview::wait_for_first_camera_frame
• Error handling