improvement: Show custom domain TXT record #879
Conversation
WalkthroughAdds TXT DNS verification UI to the verify step (shown when TXT records exist and domain is not verified) and changes the CustomDomain action button to show spinner/disabled only when the domain is verified and the remove mutation is pending. No public API changes. Changes
Sequence Diagram(s)sequenceDiagram
participant U as User
participant VS as VerifyStep
participant DC as domainConfig.verification
participant CB as Clipboard
U->>VS: Open Verify Step
VS->>DC: Read verification records
DC-->>VS: TXT records (if any)
alt has TXT and not verified
VS->>U: Render TXT Records panel
U->>VS: Click Copy on a record
VS->>CB: Write value to clipboard
CB-->>VS: Success
VS-->>U: Show copied feedback
else No TXT or already verified
VS-->>U: Skip TXT panel
end
sequenceDiagram
participant U as User
participant CD as CustomDomain
participant RM as removeDomainMutation
U->>CD: View domain row
alt isVerified
CD->>RM: Observe isPending
CD-->>U: Show Remove button (spinner/disabled if pending)
U->>CD: Click Remove
CD->>RM: mutate(remove)
else not verified
CD-->>U: Show Setup button (no spinner/disabled)
U->>CD: Click Setup
CD-->>U: Proceed to setup flow
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~15 minutes Possibly related PRs
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
✨ Finishing Touches
🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
apps/web/app/(org)/dashboard/settings/organization/components/CustomDomain.tsx(2 hunks)apps/web/app/(org)/dashboard/settings/organization/components/CustomDomainDialog/VerifyStep.tsx(3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Build Desktop (aarch64-apple-darwin, macos-latest)
- GitHub Check: Build Desktop (x86_64-pc-windows-msvc, windows-latest)
🔇 Additional comments (6)
apps/web/app/(org)/dashboard/settings/organization/components/CustomDomain.tsx (2)
98-98: Minor CSS class ordering changeThe class order change from "text-white text-xs" to "text-xs text-white" doesn't affect functionality but improves consistency with typical utility-first ordering patterns.
148-149: Improved button state management for unverified domainsGood improvement! The conditional spinner and disabled states now only apply when the domain is verified, preventing the button from being disabled during the setup flow. This ensures users can interact with the "Setup" button even if other operations are pending.
apps/web/app/(org)/dashboard/settings/organization/components/CustomDomainDialog/VerifyStep.tsx (4)
34-37: LGTM: Clean extraction of verification recordsThe extraction of
verificationRecordsandhasTXTVerificationflag follows the existing pattern and provides clear semantic meaning for the TXT verification feature.
69-69: Proper conditional rendering logic for TXT recordsThe
showTXTRecordcondition correctly shows TXT records only when verification records exist and the domain is not yet verified, maintaining consistency with the A and CNAME record logic.
118-184: Well-structured TXT record configuration panelThe TXT record configuration panel follows the established UI patterns from A and CNAME record sections. The implementation includes:
- Consistent styling and layout
- Proper copy-to-clipboard functionality
- Clear labeling and instructions
- Responsive grid layout
The code reuses existing components and maintains visual consistency across the verification UI.
131-180: DomainVerification fields are correctly typedThe
DomainVerificationtype explicitly definestype,domain, andvalue, so the JSX mapping oververificationRecordsis safe and no changes are needed.
This PR: make sure to show required TXT record.
Summary by CodeRabbit