Biome #876
Merged
Biome #876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Caution Review failedThe pull request is closed. WalkthroughRepository-wide formatting normalization (tabs), added Biome format/lint CI jobs, a new .git-blame-ignore-revs entry, many type-only import refinements, and desktop app changes including S3 config event-bus UI, notification-permission gating in settings, startup UX tweaks with persisted audio state, camera window sizing via Tauri, and a large captions editor refactor. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant UI as CaptionsTab
participant FS as FileSystem
participant API as Transcription API
participant Project as ProjectState
User->>UI: Open Captions tab
UI->>FS: Check model presence
alt model missing
UI->>FS: Download model (progress)
FS-->>UI: Progress updates / completion
end
User->>UI: Click "Generate Captions"
UI->>API: transcribeAudio(project audio)
API-->>UI: Return segments
UI->>Project: Update project.captions
Project-->>User: Render captions
sequenceDiagram
participant User
participant Page as S3 Config Page
participant Bus as EventBus
participant Svc as Backend
participant Dialog as GlobalDialog
User->>Page: Click "Save"
Page->>Bus: emit("save")
Bus->>Svc: saveConfig(payload)
Svc-->>Bus: OK
Bus-->>Page: Success
Page->>Dialog: show("S3 configuration saved")
Page->>Svc: refetch config
User->>Page: Click "Test"
Page->>Bus: emit("test" with AbortController)
Bus->>Svc: testConfig(payload)
alt Timeout/Abort
Svc--x Bus: AbortError
Page->>Dialog: show("Test timed out")
else Success
Svc-->>Bus: OK
Page->>Dialog: show("Connection successful")
end
sequenceDiagram
participant User
participant Cam as Camera Route
participant Mon as currentMonitor
participant Win as Tauri Window
User->>Cam: Open camera preview
Cam->>Mon: get monitor dimensions
Cam->>Cam: compute LogicalSize/Position
Cam->>Win: setSize / setPosition
Win-->>User: Window resized and positioned
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (55)
✨ Finishing Touches
🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
Contributor
|
lgtm |
Contributor
Author
|
@coderabbitai this is past your pay grade. |
Contributor
|
Tip For best results, initiate chat on the files or code changes. @oscartbeaumont Haha, fair enough! 😄 Looks like Brendonovich has already given this the green light, and adding Biome is pretty straightforward tooling work. I'll step aside and let the humans handle this one! 🐰 |
Contributor
|
Tip For best results, initiate chat on the files or code changes. @oscartbeaumont You're absolutely right! Tooling decisions like adding Biome often involve project-specific preferences, team workflows, and context that goes beyond just the technical implementation. I'm happy to defer to the team's judgment on this one - looks like Brendonovich has it covered! 🐰 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brendan said he wanted it and I want something to do while Windows compiles 😅
Summary by CodeRabbit
New Features
Improvements
Style
Chores