Skip to content

fix: clamp instant recording output to even minimum size #1309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
richiemcilroy merged 1 commit into from
Oct 28, 2025
Merged

fix: clamp instant recording output to even minimum size #1309

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 13 additions & 32 deletions crates/recording/src/instant_recording.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,65 +399,46 @@ fn current_time_f64() -> f64 {
.as_secs_f64()
}

fn ensure_even(value: u32) -> u32 {
let adjusted = value - (value % 2);
if adjusted == 0 { 2 } else { adjusted }
}

fn clamp_size(input: (u32, u32), max: (u32, u32)) -> (u32, u32) {
// 16/9-ish
if input.0 >= input.1 && (input.0 as f64 / input.1 as f64) <= 16.0 / 9.0 {
let mut width = max.0.min(input.0);
if width.is_multiple_of(2) {
width -= 1;
}
let width = ensure_even(max.0.min(input.0));

let height_ratio = input.1 as f64 / input.0 as f64;
let mut height = (height_ratio * width as f64).round() as u32;
if height.is_multiple_of(2) {
height -= 1;
}
let height = ensure_even((height_ratio * width as f64).round() as u32);

(width, height)
}
// 9/16-ish
else if input.0 <= input.1 && (input.0 as f64 / input.1 as f64) >= 9.0 / 16.0 {
let mut height = max.0.min(input.1);
if height.is_multiple_of(2) {
height -= 1;
}
let height = ensure_even(max.0.min(input.1));

let width_ratio = input.0 as f64 / input.1 as f64;
let mut width = (width_ratio * height as f64).round() as u32;
if width.is_multiple_of(2) {
width -= 1;
}
let width = ensure_even((width_ratio * height as f64).round() as u32);

(width, height)
}
// ultrawide
else if input.0 >= input.1 && (input.0 as f64 / input.1 as f64) > 16.0 / 9.0 {
let mut height = max.1.min(input.1);
if height.is_multiple_of(2) {
height -= 1;
}
let height = ensure_even(max.1.min(input.1));

let width_ratio = input.0 as f64 / input.1 as f64;
let mut width = (width_ratio * height as f64).round() as u32;
if width.is_multiple_of(2) {
width -= 1;
}
let width = ensure_even((width_ratio * height as f64).round() as u32);

(width, height)
}
// ultratall
else if input.0 < input.1 && (input.0 as f64 / input.1 as f64) <= 9.0 / 16.0 {
// swapped since max_width/height assume horizontal
let mut width = max.1.min(input.0);
if width.is_multiple_of(2) {
width -= 1;
}
let width = ensure_even(max.1.min(input.0));

let height_ratio = input.1 as f64 / input.0 as f64;
let mut height = (height_ratio * width as f64).round() as u32;
if height.is_multiple_of(2) {
height -= 1;
}
let height = ensure_even((height_ratio * width as f64).round() as u32);

(width, height)
} else {
Expand Down