Skip to content

Use Rec709 color space in cap_enc_avfoundation #1177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Brendonovich merged 2 commits into from
Oct 13, 2025
Merged

Use Rec709 color space in cap_enc_avfoundation #1177

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e452fdb
use rec709 color space in cap_enc_avfoundation
Brendonovich Oct 13, 2025
d4b98b5
cleanup
Brendonovich Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apps/desktop/src-tauri/src/recording.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -485,8 +485,8 @@ pub async fn start_recording(
)
.await
.map_err(|e| {
error!("Failed to spawn studio recording actor: {e}");
e.to_string()
error!("Failed to spawn studio recording actor: {e:#}");
format!("{e:#}")
})?;

InProgressRecording::Studio { handle, common }
Expand Down
26 changes: 25 additions & 1 deletion crates/enc-avfoundation/src/mp4.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,23 @@ impl MP4Encoder {
.as_id_ref(),
);

output_settings.insert(
av::video_settings_keys::color_props(),
ns::Dictionary::with_keys_values(
&[
unsafe { AVVideoTransferFunctionKey },
unsafe { AVVideoColorPrimariesKey },
unsafe { AVVideoYCbCrMatrixKey },
],
&[
unsafe { AVVideoTransferFunction_ITU_R_709_2 },
unsafe { AVVideoColorPrimaries_ITU_R_709_2 },
unsafe { AVVideoYCbCrMatrix_ITU_R_709_2 },
],
)
.as_id_ref(),
);

let mut video_input = av::AssetWriterInput::with_media_type_and_output_settings(
av::MediaType::video(),
Some(output_settings.as_ref()),
Expand Down Expand Up @@ -370,7 +387,14 @@ impl Drop for MP4Encoder {

#[link(name = "AVFoundation", kind = "framework")]
unsafe extern "C" {
static AVVideoAverageBitRateKey: &'static cidre::ns::String;
static AVVideoAverageBitRateKey: &'static ns::String;
static AVVideoTransferFunctionKey: &'static ns::String;
static AVVideoColorPrimariesKey: &'static ns::String;
static AVVideoYCbCrMatrixKey: &'static ns::String;

static AVVideoTransferFunction_ITU_R_709_2: &'static cidre::ns::String;
static AVVideoColorPrimaries_ITU_R_709_2: &'static cidre::ns::String;
static AVVideoYCbCrMatrix_ITU_R_709_2: &'static cidre::ns::String;
}

unsafe fn result_unchecked<T, R>(op: impl FnOnce(&mut Option<T>) -> R) -> cidre::os::Result<T>
Expand Down
Loading