Skip to content

fix: logging in from video page #1082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ameer2468 merged 5 commits into from
Sep 26, 2025
+384 −161
Merged

fix: logging in from video page #1082

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
007bd9d
fix logging in from share page
ameer2468 Sep 26, 2025
0f4c3c6
Update AuthOverlay.tsx
ameer2468 Sep 26, 2025
02dba81
Update OtpForm.tsx
ameer2468 Sep 26, 2025
bbf0106
improve bg color
ameer2468 Sep 26, 2025
37f7880
Update OtpForm.tsx
ameer2468 Sep 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 12 additions & 15 deletions apps/web/app/(org)/login/form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ export function LoginForm() {
</motion.p>
</motion.div>
<MotionLink layout="position" className="flex mx-auto size-fit" href="/">
<MotionLogoBadge layout="position" className="w-[72px] h-[72px]" />
<MotionLogoBadge layout="position" className="size-12" />
</MotionLink>
<motion.div
layout="position"
Expand Down Expand Up @@ -459,18 +459,16 @@ const NormalLogin = ({
className="flex flex-col gap-3 justify-center items-center"
>
{!oauthError && (
<>
<MotionButton
variant="gray"
type="button"
className="flex gap-2 justify-center items-center w-full text-sm"
onClick={handleGoogleSignIn}
disabled={loading}
>
<Image src="/google.svg" alt="Google" width={16} height={16} />
Login with Google
</MotionButton>
</>
<MotionButton
variant="gray"
type="button"
className="flex gap-2 justify-center items-center w-full text-sm"
onClick={handleGoogleSignIn}
disabled={loading}
>
<Image src="/google.svg" alt="Google" width={16} height={16} />
Login with Google
</MotionButton>
)}

{oauthError && (
Expand All @@ -481,8 +479,7 @@ const NormalLogin = ({
/>
<p className="text-xs leading-5 text-gray-50">
It looks like you've previously used this email to sign up via
email login. Please enter your email below to receive a sign in
link.
email login. Please enter your email.
</p>
</div>
)}
Expand Down
12 changes: 6 additions & 6 deletions apps/web/app/(org)/verify-otp/form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,19 +156,19 @@ export function VerifyOTPForm({
</Link>

<Link className="flex mx-auto size-fit" href="/">
<LogoBadge className="w-[72px] h-[72px]" />
<LogoBadge className="size-12" />
</Link>

<div className="flex flex-col justify-center items-center my-7 text-center">
<h1 className="text-2xl font-semibold text-gray-12">
<h1 className="text-xl font-semibold text-gray-12">
Enter verification code
</h1>
<p className="text-[16px] text-gray-10 mt-2">
<p className="text-sm text-gray-10">
We sent a 6-digit code to {email}
</p>
</div>

<div className="flex gap-2 justify-center mb-6">
<div className="flex flex-1 gap-2 justify-between mb-5">
{code.map((digit, index) => (
<input
key={index.toString()}
Expand All @@ -191,7 +191,7 @@ export function VerifyOTPForm({
.replace(/\D/g, "");
handleChange(0, pastedData);
}}
className="w-12 h-14 text-xl font-semibold text-center rounded-lg border transition-all bg-gray-1 border-gray-5 focus:outline-none focus:ring-2 focus:ring-blue-500 focus:border-transparent"
className="flex-1 h-[52px] text-xl font-semibold text-center rounded-lg border transition-all bg-gray-1 border-gray-5 focus:outline-none focus:ring-2 focus:ring-blue-500 focus:border-transparent"
disabled={handleVerify.isPending || handleVerify.isSuccess}
/>
))}
Expand Down Expand Up @@ -221,7 +221,7 @@ export function VerifyOTPForm({
</div>

<p className="mt-6 text-xs text-center text-gray-9">
By verifying your email, you acknowledge that you have both read and
By entering your email, you acknowledge that you have both read and
Copy link
Contributor

@coderabbitai coderabbitai bot Sep 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Minor inconsistency in copy text.

The text says "By entering your email" but this is the OTP verification form where users are entering a code, not their email. Consider updating to "By verifying your email" to match the context.

-				By entering your email, you acknowledge that you have both read and
+				By verifying your email, you acknowledge that you have both read and
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
By entering your email, you acknowledge that you have both read and
By verifying your email, you acknowledge that you have both read and
🤖 Prompt for AI Agents 
In apps/web/app/(org)/verify-otp/form.tsx around line 224, the copy reads "By
entering your email" which is inconsistent for the OTP verification form; change
the wording to "By verifying your email" (or similar context-appropriate
phrasing) so the message matches that users are entering a verification code
rather than an email, and update any adjacent punctuation/capitalization to
match existing style.

agree to Cap's{" "}
<Link
href="/terms"
Expand Down
Loading
Loading