Skip to content

Commit

Permalink
chore(build): do not configure execution in plugin mgmt
Browse files Browse the repository at this point in the history 
- this triggers the execution as soon as the plugin is configured
  anywhere in the POM hierarchy
- this was the case when we added the dependency plugin to the release
  parent

related to CAM-10419
  • Loading branch information
@ThorbenLindhauer @yanavasileva
ThorbenLindhauer authored and yanavasileva committed May 5, 2020
1 parent d0228a1 commit 17aa3ae
Show file tree
Hide file tree
Showing 11 changed files with 234 additions and 333 deletions.
51 changes: 21 additions & 30 deletions qa/test-db-instance-migration/test-fixture-710/pom.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -67,36 +67,6 @@
<filtering>true</filtering>
</testResource>
</testResources>

<pluginManagement>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-dependency-plugin</artifactId>
<executions>
<execution>
<id>unpack-current-sql-scripts</id>
<phase>generate-test-sources</phase>
<goals>
<goal>unpack</goal>
</goals>
<configuration>
<artifactItems>
<artifactItem>
<groupId>org.camunda.bpm.distro</groupId>
<artifactId>camunda-sql-scripts</artifactId>
<version>7.10.0</version>
<type>test-jar</type>
<outputDirectory>${project.build.directory}/scripts-current</outputDirectory>
<overWrite>true</overWrite>
</artifactItem>
</artifactItems>
</configuration>
</execution>
</executions>
</plugin>
</plugins>
</pluginManagement>
</build>

<profiles>
Expand Down Expand Up @@ -146,6 +116,27 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-dependency-plugin</artifactId>
<executions>
<execution>
<id>unpack-current-sql-scripts</id>
<phase>generate-test-sources</phase>
<goals>
<goal>unpack</goal>
</goals>
<configuration>
<artifactItems>
<artifactItem>
<groupId>org.camunda.bpm.distro</groupId>
<artifactId>camunda-sql-scripts</artifactId>
<version>7.10.0</version>
<type>test-jar</type>
<outputDirectory>${project.build.directory}/scripts-current</outputDirectory>
<overWrite>true</overWrite>
</artifactItem>
</artifactItems>
</configuration>
</execution>
</executions>
</plugin>

<!-- parse version properties from qa/pom.xml -->
Expand Down
51 changes: 21 additions & 30 deletions qa/test-db-instance-migration/test-fixture-711/pom.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -63,36 +63,6 @@
<filtering>true</filtering>
</testResource>
</testResources>

<pluginManagement>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-dependency-plugin</artifactId>
<executions>
<execution>
<id>unpack-current-sql-scripts</id>
<phase>generate-test-sources</phase>
<goals>
<goal>unpack</goal>
</goals>
<configuration>
<artifactItems>
<artifactItem>
<groupId>org.camunda.bpm.distro</groupId>
<artifactId>camunda-sql-scripts</artifactId>
<version>7.11.0</version>
<type>test-jar</type>
<outputDirectory>${project.build.directory}/scripts-current</outputDirectory>
<overWrite>true</overWrite>
</artifactItem>
</artifactItems>
</configuration>
</execution>
</executions>
</plugin>
</plugins>
</pluginManagement>
</build>

<profiles>
Expand Down Expand Up @@ -142,6 +112,27 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-dependency-plugin</artifactId>
<executions>
<execution>
<id>unpack-current-sql-scripts</id>
<phase>generate-test-sources</phase>
<goals>
<goal>unpack</goal>
</goals>
<configuration>
<artifactItems>
<artifactItem>
<groupId>org.camunda.bpm.distro</groupId>
<artifactId>camunda-sql-scripts</artifactId>
<version>7.11.0</version>
<type>test-jar</type>
<outputDirectory>${project.build.directory}/scripts-current</outputDirectory>
<overWrite>true</overWrite>
</artifactItem>
</artifactItems>
</configuration>
</execution>
</executions>
</plugin>

<!-- parse version properties from qa/pom.xml -->
Expand Down
53 changes: 22 additions & 31 deletions qa/test-db-instance-migration/test-fixture-712/pom.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -63,37 +63,6 @@
<filtering>true</filtering>
</testResource>
</testResources>

<pluginManagement>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-dependency-plugin</artifactId>
<executions>
<execution>
<id>unpack-current-sql-scripts</id>
<phase>generate-test-sources</phase>
<goals>
<goal>unpack</goal>
</goals>
<configuration>
<artifactItems>
<artifactItem>
<groupId>org.camunda.bpm.distro</groupId>
<artifactId>camunda-sql-scripts</artifactId>
<version>${camunda.version.current}</version>
<version>7.12.0</version>
<type>test-jar</type>
<outputDirectory>${project.build.directory}/scripts-current</outputDirectory>
<overWrite>true</overWrite>
</artifactItem>
</artifactItems>
</configuration>
</execution>
</executions>
</plugin>
</plugins>
</pluginManagement>
</build>

<profiles>
Expand Down Expand Up @@ -143,6 +112,28 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-dependency-plugin</artifactId>
<executions>
<execution>
<id>unpack-current-sql-scripts</id>
<phase>generate-test-sources</phase>
<goals>
<goal>unpack</goal>
</goals>
<configuration>
<artifactItems>
<artifactItem>
<groupId>org.camunda.bpm.distro</groupId>
<artifactId>camunda-sql-scripts</artifactId>
<version>${camunda.version.current}</version>
<version>7.12.0</version>
<type>test-jar</type>
<outputDirectory>${project.build.directory}/scripts-current</outputDirectory>
<overWrite>true</overWrite>
</artifactItem>
</artifactItems>
</configuration>
</execution>
</executions>
</plugin>

<!-- parse version properties from qa/pom.xml -->
Expand Down
55 changes: 23 additions & 32 deletions qa/test-db-instance-migration/test-fixture-713/pom.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -66,38 +66,6 @@
<filtering>true</filtering>
</testResource>
</testResources>

<pluginManagement>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-dependency-plugin</artifactId>
<executions>
<execution>
<id>unpack-current-sql-scripts</id>
<phase>generate-test-sources</phase>
<goals>
<goal>unpack</goal>
</goals>
<configuration>
<artifactItems>
<artifactItem>
<groupId>org.camunda.bpm.distro</groupId>
<artifactId>camunda-sql-scripts</artifactId>
<!-- Replace after 7.13.0 release -->
<version>${camunda.version.current}</version>
<!--<version>7.13.0</version>-->
<type>test-jar</type>
<outputDirectory>${project.build.directory}/scripts-current</outputDirectory>
<overWrite>true</overWrite>
</artifactItem>
</artifactItems>
</configuration>
</execution>
</executions>
</plugin>
</plugins>
</pluginManagement>
</build>

<profiles>
Expand Down Expand Up @@ -147,6 +115,29 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-dependency-plugin</artifactId>
<executions>
<execution>
<id>unpack-current-sql-scripts</id>
<phase>generate-test-sources</phase>
<goals>
<goal>unpack</goal>
</goals>
<configuration>
<artifactItems>
<artifactItem>
<groupId>org.camunda.bpm.distro</groupId>
<artifactId>camunda-sql-scripts</artifactId>
<!-- Replace after 7.13.0 release -->
<version>${camunda.version.current}</version>
<!--<version>7.13.0</version>-->
<type>test-jar</type>
<outputDirectory>${project.build.directory}/scripts-current</outputDirectory>
<overWrite>true</overWrite>
</artifactItem>
</artifactItems>
</configuration>
</execution>
</executions>
</plugin>

<!-- parse version properties from qa/pom.xml -->
Expand Down
51 changes: 21 additions & 30 deletions qa/test-db-instance-migration/test-fixture-73/pom.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -56,36 +56,6 @@
<filtering>true</filtering>
</testResource>
</testResources>

<pluginManagement>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-dependency-plugin</artifactId>
<executions>
<execution>
<id>unpack-current-sql-scripts</id>
<phase>generate-test-sources</phase>
<goals>
<goal>unpack</goal>
</goals>
<configuration>
<artifactItems>
<artifactItem>
<groupId>org.camunda.bpm.distro</groupId>
<artifactId>camunda-sql-scripts</artifactId>
<version>7.3.0</version>
<type>test-jar</type>
<outputDirectory>${project.build.directory}/scripts-current</outputDirectory>
<overWrite>true</overWrite>
</artifactItem>
</artifactItems>
</configuration>
</execution>
</executions>
</plugin>
</plugins>
</pluginManagement>
</build>

<profiles>
Expand Down Expand Up @@ -144,6 +114,27 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-dependency-plugin</artifactId>
<executions>
<execution>
<id>unpack-current-sql-scripts</id>
<phase>generate-test-sources</phase>
<goals>
<goal>unpack</goal>
</goals>
<configuration>
<artifactItems>
<artifactItem>
<groupId>org.camunda.bpm.distro</groupId>
<artifactId>camunda-sql-scripts</artifactId>
<version>7.3.0</version>
<type>test-jar</type>
<outputDirectory>${project.build.directory}/scripts-current</outputDirectory>
<overWrite>true</overWrite>
</artifactItem>
</artifactItems>
</configuration>
</execution>
</executions>
</plugin>

<!-- parse version properties from qa/pom.xml -->
Expand Down
51 changes: 21 additions & 30 deletions qa/test-db-instance-migration/test-fixture-74/pom.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -55,36 +55,6 @@
<filtering>true</filtering>
</testResource>
</testResources>

<pluginManagement>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-dependency-plugin</artifactId>
<executions>
<execution>
<id>unpack-current-sql-scripts</id>
<phase>generate-test-sources</phase>
<goals>
<goal>unpack</goal>
</goals>
<configuration>
<artifactItems>
<artifactItem>
<groupId>org.camunda.bpm.distro</groupId>
<artifactId>camunda-sql-scripts</artifactId>
<version>7.4.0</version>
<type>test-jar</type>
<outputDirectory>${project.build.directory}/scripts-current</outputDirectory>
<overWrite>true</overWrite>
</artifactItem>
</artifactItems>
</configuration>
</execution>
</executions>
</plugin>
</plugins>
</pluginManagement>
</build>

<profiles>
Expand Down Expand Up @@ -155,6 +125,27 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-dependency-plugin</artifactId>
<executions>
<execution>
<id>unpack-current-sql-scripts</id>
<phase>generate-test-sources</phase>
<goals>
<goal>unpack</goal>
</goals>
<configuration>
<artifactItems>
<artifactItem>
<groupId>org.camunda.bpm.distro</groupId>
<artifactId>camunda-sql-scripts</artifactId>
<version>7.4.0</version>
<type>test-jar</type>
<outputDirectory>${project.build.directory}/scripts-current</outputDirectory>
<overWrite>true</overWrite>
</artifactItem>
</artifactItems>
</configuration>
</execution>
</executions>
</plugin>

<!-- parse version properties from qa/pom.xml -->
Expand Down
Loading

0 comments on commit 17aa3ae

Please sign in to comment.