Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organization system #315

Closed
wants to merge 16 commits into from
Closed

Organization system #315

wants to merge 16 commits into from

Conversation

pbkompasz
Copy link
Contributor

@pbkompasz pbkompasz commented Aug 28, 2023

Part of #258

@netlify
Copy link

netlify bot commented Aug 28, 2023

👷 Deploy request for webcapgo accepted.

Name Link
🔨 Latest commit 7453b7e
🔍 Latest deploy log https://app.netlify.com/sites/webcapgo/deploys/64ecbd2d86a0800008cb69da

@sonarcloud
Copy link

sonarcloud bot commented Aug 28, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 13 Code Smells

No Coverage information No Coverage information
30.0% 30.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@WcaleNieWolny
Copy link
Contributor

WcaleNieWolny commented Aug 30, 2023

What is your vision for this members panel? I have a couple of questions.

A) What is member.position member.role These values are not present in the current db scheme and I am not sure what they suppose to be.
B) What is members.value = organizationStore.getMembers(currentOrganization.id)? getMembers does not exist
C) How does the member tab should look like? I managed to get the members pannel to the following state, however I really do not like how it looks

image

@WcaleNieWolny
Copy link
Contributor

Also please explain what on earth is the get_orgs function. I thought that the assumption was that if you are owner of an organization you are not in members of said organization

@WcaleNieWolny
Copy link
Contributor

It it pointless to have the owner in members. He cannot remove himself from the guild nor can he change his own role

@pbkompasz pbkompasz closed this by deleting the head repository Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants