Skip to content

fix(android): skip CryptoObject for verifyIdentity to prevent crash - #103

Merged
riderx merged 1 commit into
mainfrom
fix/verify-identity-skip-crypto
Jul 9, 2026
Merged

fix(android): skip CryptoObject for verifyIdentity to prevent crash#103
riderx merged 1 commit into
mainfrom
fix/verify-identity-skip-crypto

Conversation

@riderx

@riderx riderx commented Jul 9, 2026

Copy link
Copy Markdown
Member

Summary

  • Fixes the crash/failure in verifyIdentity() on Android when the default authenticator config requires a CryptoObject while also allowing BIOMETRIC_WEAK.
  • Skips CryptoObject creation and validation in AuthActivity when mode is verify (the default for verifyIdentity()).
  • Secure credential modes keep the crypto path unchanged.
  • Based on community PR Skip requiresCryptoObject branch for verifyIdentity to prevent crash #102

Test plan

  • bun run verify:android passes locally
  • Call NativeBiometric.verifyIdentity() on Android without allowedBiometryTypes — prompt should open and succeed without IllegalArgumentException
  • Call verifyIdentity({ allowedBiometryTypes: [BiometryType.FINGERPRINT] }) — should succeed without "Biometric security check failed"
  • Confirm setSecureCredentials / getSecureCredentials with access control still use CryptoObject path

Made with Cursor

verifyIdentity does not need keystore crypto, but the default config
sets requiresCryptoObject=true, which crashes BiometricPrompt when
BIOMETRIC_WEAK is allowed and can fail crypto validation after success.

Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Jul 9, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 52 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 2b46e7c5-c320-4955-bd1d-6146bfa7d653

📥 Commits

Reviewing files that changed from the base of the PR and between 3996383 and ba8fb1e.

📒 Files selected for processing (1)
  • android/src/main/java/ee/forgr/biometric/AuthActivity.java

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown

Beta npm build

Maintainers can publish this PR to npm for fast testing.

Comment /publish-beta after the PR checks are green.

The workflow will:

  • publish a prerelease package on the beta tag
  • add a pinned pr-103 dist-tag for this exact PR build
  • update this comment with the install command

Security note: beta publish is only enabled for branches inside this repository.

@riderx
riderx marked this pull request as ready for review July 9, 2026 08:20

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Risk: low. Approved: Cursor Bugbot was not present on this PR, all other checks passed, and this is a narrow Android fix that skips CryptoObject only for verify mode while leaving secure credential paths unchanged. No reviewers assigned.

Open in Web View Automation 

Sent by Cursor Approval Agent: Pull Request Approver External

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Risk: medium. Cursor Bugbot was not present on this PR; all CI checks passed. Approved the narrow Android fix that skips CryptoObject only for verify mode while leaving secure credential paths unchanged. No reviewers assigned.

Open in Web View Automation 

Sent by Cursor Approval Agent: Pull Request Approver

@riderx
riderx merged commit 590d7cf into main Jul 9, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant