fix(android): skip CryptoObject for verifyIdentity to prevent crash - #103
Conversation
verifyIdentity does not need keystore crypto, but the default config sets requiresCryptoObject=true, which crashes BiometricPrompt when BIOMETRIC_WEAK is allowed and can fail crypto validation after success. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 52 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
Comment |
Beta npm buildMaintainers can publish this PR to npm for fast testing. Comment The workflow will:
Security note: beta publish is only enabled for branches inside this repository. |


Summary
verifyIdentity()on Android when the default authenticator config requires aCryptoObjectwhile also allowingBIOMETRIC_WEAK.CryptoObjectcreation and validation in AuthActivity whenmodeisverify(the default forverifyIdentity()).requiresCryptoObjectbranch forverifyIdentityto prevent crash #102Test plan
bun run verify:androidpasses locallyNativeBiometric.verifyIdentity()on Android withoutallowedBiometryTypes— prompt should open and succeed withoutIllegalArgumentExceptionverifyIdentity({ allowedBiometryTypes: [BiometryType.FINGERPRINT] })— should succeed without "Biometric security check failed"setSecureCredentials/getSecureCredentialswith access control still use CryptoObject pathMade with Cursor