Skip to content

fix node patches in node 20.12#53

Merged
bradzacher merged 4 commits intomainfrom
bradzacher-patch-1
Apr 24, 2024
Merged

fix node patches in node 20.12#53
bradzacher merged 4 commits intomainfrom
bradzacher-patch-1

Conversation

@bradzacher
Copy link
Member

@bradzacher bradzacher commented Apr 24, 2024

https://buildkite.com/canva-org/canva-web-build/builds/1432323#018f0aab-98b7-4ef7-8e2c-b975f8fa53ae/1464-1530

2024-04-23T11:21:59.249Z @canva/bazel/worker:error failed to run build: TypeError: The "paths[0]" argument must be of type string. Received an instance of Buffer
     at Object.resolve (node:path:1101:7)
     at fs.readdirSync (/mnt/ephemeral/bazel_user_root_2/a8584ebfb3d6ff0dfe61abfbfa5bb4d3/external/build_bazel_rules_nodejs/internal/node/node_patches.js:250:35)
     at _rmdirSync (node:internal/fs/rimraf:250:29)
     at rimrafSync (node:internal/fs/rimraf:193:7)
     at Object.rmSync (node:fs:1265:10)
     at buildPage (/var/lib/buildkite-agent/builds/canva__canva/web/tools/bazel/webpack/cli/webpack_cli.ts:50:6)
     at /var/lib/buildkite-agent/builds/canva__canva/web/tools/bazel/webpack/cli/webpack_cli.ts:219:5
     at runOneBuild (/var/lib/buildkite-agent/builds/canva__canva/web/tools/bazel/worker/worker_bootstrapper.ts:125:39)
     at /var/lib/buildkite-agent/builds/canva__canva/web/tools/bazel/worker/worker.ts:170:32
     at processTicksAndRejections (node:internal/process/task_queues:95:5) {
   code: 'ERR_INVALID_ARG_TYPE'
}

Fixes this error in node 20.12.2

output of bazel build //tools/build/nodejs/builtins_patcher:bundle in the monorepo run on top of https://github.com/Canva/canva/pull/495796

@bradzacher bradzacher merged commit 2890851 into main Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants