Skip to content

Remove unused npm_umd_bundle rule and generated targets#50

Merged
Silic0nS0ldier merged 1 commit intomainfrom
jordan-mele_no-umd
Feb 7, 2024
Merged

Remove unused npm_umd_bundle rule and generated targets#50
Silic0nS0ldier merged 1 commit intomainfrom
jordan-mele_no-umd

Conversation

@Silic0nS0ldier
Copy link
Contributor

@Silic0nS0ldier Silic0nS0ldier commented Feb 7, 2024 •
edited
Loading

This PR removes functionality we are not using.

  • @[repo_name]//[{package_scope}/]{package_name}:{package_name}__umd target.
  • @[repo_name]//[{package_scope}/]{package_name}:{package_name}__umd_directory_file_path target.
  • npm_umd_bundle rule.

Aside from reducing ruleset complexity, this should also slightly reduce the amount of work Bazel has to do (less time parsing and running BUILD files, less time generating BUILD files in yarn_install repo rule).

TODO

  • Testing

@Silic0nS0ldier Silic0nS0ldier marked this pull request as ready for review February 7, 2024 04:52
@Silic0nS0ldier Silic0nS0ldier merged commit 5f628f4 into main Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@christianscott christianscott christianscott approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Silic0nS0ldier @christianscott