Skip to content

nodejs_binary: remove dependency on :node_bin#44

Merged
christianscott merged 2 commits intomainfrom
christianscott-remove_dep_on_node_bin
Dec 22, 2023
Merged

nodejs_binary: remove dependency on :node_bin#44
christianscott merged 2 commits intomainfrom
christianscott-remove_dep_on_node_bin

Conversation

@christianscott
Copy link
Contributor

@christianscott christianscott commented Dec 22, 2023

before

# bazel cquery --config=remote_config 'somepath(//some/nodejs_binary:target, @nodejs_darwin_arm64//:node_bin)'
//some/nodejs_binary:target (7160162)
@nodejs//:node_bin (7160162)
@nodejs_darwin_arm64//:node_bin (7160162)

after:

# bazel cquery --config=remote_config 'somepath(//some/nodejs_binary:target, @nodejs_darwin_arm64//:node_bin)'
INFO: Empty query results

Copy link
Contributor

@Silic0nS0ldier Silic0nS0ldier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That this fixes the issue likely points to some flaw in how Bazel 7 builds the repo mapping file.

Regardless of the reasons, this is a net positive change and one I am familiar with from my work in the overhaul branch. (lib/private/rules/nodejs_binary_test/attrs.bzl has no references to @nodejs)

@christianscott christianscott merged commit 5a824c3 into main Dec 22, 2023
@Silic0nS0ldier Silic0nS0ldier deleted the christianscott-remove_dep_on_node_bin branch February 7, 2024 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants