Change max duration to max float64 (v0.47.0) #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbthanh90
pushed a commit
that referenced
this pull request
Apr 4, 2022
This reverts commit 8b97c75.
tbthanh90
pushed a commit
that referenced
this pull request
Apr 4, 2022
jaskerv
pushed a commit
that referenced
this pull request
Apr 29, 2022
jaskerv
pushed a commit
that referenced
this pull request
Apr 29, 2022
jaskerv
pushed a commit
that referenced
this pull request
Apr 29, 2022
jaskerv
pushed a commit
that referenced
this pull request
Apr 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
As defaultLatencyHistogramBucketsMs is an array of float64, we need to change maxDurationMs to max of float64
If we keep maxDurationMs as max of Int64, and the duration is more than max of Int64, it might cause panic at https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/processor/spanmetricsprocessor/processor.go#L439
Link to tracking Issue:
https://canvadev.atlassian.net/browse/ODC-541
Testing:
Tested in dev cluster