Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing external getManifest to only return the exact manifest requested. #37

Merged
merged 2 commits into from
Jun 13, 2016
Merged

Changing external getManifest to only return the exact manifest requested. #37

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec34141
Changing external getManifest to only return the exact manifest reque…
joeldenning Jun 10, 2016
216087c
Adding helpful comments
joeldenning Jun 10, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Adding helpful comments
  • Loading branch information
@joeldenning
joeldenning committed Jun 10, 2016
commit 216087c2c4c0bf1563bfd02eca27cc6735e6e744
5 changes: 5 additions & 0 deletions src/sofe.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,13 @@ export function getManifest(url) {
}

return new Promise((resolve, reject) => {
// Ensure that the manifest for this url has been retrieved
_getManifest({manifestUrl: url})
.then(() => {
/* We don't want the merged combination of all of the chained manifests,
* which is what _getManifest returns. Instead, we want *just* the manifest
* exactly as it is found at the specified url.
*/
getAllManifests()
.then(manifests => {
resolve(manifests.all[url].manifest)
Expand Down