Added feature for chaining manifests together (fixes #19). Also fixed… #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is
|
joeldenning
force-pushed
the
issues-19-and-20
branch
from
c313359 to
b6f9d12
Compare
joeldenning
force-pushed
the
issues-19-and-20
branch
from
b6f9d12 to
8c0c9eb
Compare
|
@blittle the code cov comment is out of date because I force pushed, but the comment wasn't updated / reposted. You can see the true code coverage at https://codecov.io/github/CanopyTax/sofe?branch=issues-19-and-20 |
| if (json && json.sofe) { | ||
| // First check if this manifest points to another manifest | ||
| if (typeof json.sofe.manifestUrl === 'string') { | ||
| if (visitedManifestUrls.indexOf(json.sofe.manifestUrl) >= 0) { |
|
👍 |
joeldenning
added a commit
that referenced
this pull request
Feb 29, 2016
Added feature for chaining manifests together (fixes #19). Also fixed…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… #20.