fix(ibis): Fix the incorrect data type in the test case

[douenergy]

Since we changed to use Arrow as our underlying data type system, fixed this test case.

Summary by CodeRabbit

• Tests
  • Refined Redshift connector tests to assert precise data type handling, aligning IAM and non-IAM paths (covering strings, decimals, dates, timestamps with and without time zones, nulls, and binary-like fields).
  • Improves test accuracy and consistency without changing runtime behavior or user-facing functionality.
  • Enhances confidence in Redshift integrations under different authentication methods.

[coderabbitai]

Walkthrough

Updated a Redshift test to expect specific Redshift dtype strings in the IAM credential path, aligning them with the non-IAM test. No data or control-flow changes; only assertions on dtypes were modified.

Changes

Cohort / File(s)	Summary
Redshift IAM dtype expectations ibis-server/tests/routers/v2/connector/test_redshift.py	Adjusted expected dtypes in test_query_with_aws_iam_credential to specific Redshift types (e.g., string, decimal128(5, 2), date32[day], timestamp[ns], timestamp[ns, tz=UTC], null).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

ibis, python

Poem

I thump my paws in tidy delight,
Types aligned, all columns just right.
From object fog to crystal string,
Decimals dance, timestamps sing.
In burrows of tests I softly cheer—
Precise dtypes, no bugs to fear! 🥕✨

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (2)

ibis-server/tests/routers/v2/connector/test_redshift.py (2)

160-162: Nit: Manifest declares totalprice as float while test asserts decimal128(5, 2)

If the backend intentionally coerces totalprice to a fixed-precision Decimal, consider either:

• adjusting the manifest column type comment to reflect the coercion, or
• leaving a short note in the test for future readers.

This helps reconcile the apparent mismatch between manifest type and asserted Arrow dtype.

---

145-168: DRY up expected row and dtype maps shared by both tests

Both query tests assert the same row payload and dtype mapping. Extracting shared constants reduces duplication and future drift.

Apply this diff within this test to reference shared constants:

@@
-    assert result["data"][0] == [
-        1,
-        655,
-        "O",
-        "347.61",
-        "2023-05-21",
-        "1_655",
-        "2024-01-01 23:59:59.000000",
-        "2024-01-01 23:59:59.000000 +00:00",
-        None,
-        "abc",
-    ]
-    assert result["dtypes"] == {
-        "orderkey": "int64",
-        "custkey": "int64",
-        "orderstatus": "string",
-        "totalprice": "decimal128(5, 2)",
-        "orderdate": "date32[day]",
-        "order_cust_key": "string",
-        "timestamp": "timestamp[ns]",
-        "timestamptz": "timestamp[ns, tz=UTC]",
-        "test_null_time": "null",
-        "bytea_column": "string",
-    }
+    assert result["data"][0] == EXPECTED_ROW
+    assert result["dtypes"] == EXPECTED_DTYPES

And add these shared constants near the top of the file (outside the selected range), reusing them in both tests:

# Shared expected payloads across Redshift query tests
EXPECTED_ROW = [
    1,
    655,
    "O",
    "347.61",
    "2023-05-21",
    "1_655",
    "2024-01-01 23:59:59.000000",
    "2024-01-01 23:59:59.000000 +00:00",
    None,
    "abc",
]

EXPECTED_DTYPES = {
    "orderkey": "int64",
    "custkey": "int64",
    "orderstatus": "string",
    "totalprice": "decimal128(5, 2)",
    "orderdate": "date32[day]",
    "order_cust_key": "string",
    "timestamp": "timestamp[ns]",
    "timestamptz": "timestamp[ns, tz=UTC]",
    "test_null_time": "null",
    "bytea_column": "string",
}

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 328bfcb and 93b9eb6.

📒 Files selected for processing (1)

• ibis-server/tests/routers/v2/connector/test_redshift.py (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: ci

🔇 Additional comments (1)

ibis-server/tests/routers/v2/connector/test_redshift.py (1)

160-167: LGTM: IAM path dtype expectations updated to Arrow types to match non-IAM test

This brings the IAM-credential flow in line with the standard connection test and avoids false negatives after the Arrow switch. Looks good.