Skip to content

chore: update class-validator#322

Merged
onlyjackfrost merged 1 commit into
Canner:developfrom
kenkoooo:develop
Nov 30, 2023
Merged

chore: update class-validator#322
onlyjackfrost merged 1 commit into
Canner:developfrom
kenkoooo:develop

Conversation

@kenkoooo
Copy link
Copy Markdown
Contributor

@kenkoooo kenkoooo commented Oct 25, 2023

Description

Updated class-validator because the old version had some security issues:
GHSA-fj58-h2fr-3pp2

@vercel
Copy link
Copy Markdown

vercel Bot commented Oct 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vulcan-sql-document ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2023 2:58am

@kenkoooo
Copy link
Copy Markdown
Contributor Author

@onlyjackfrost @cyyeh
Hi! It seems that some unit tests require access tokens, and I don't have the permission. As a result, the PR didn't pass the tests. Would you mind rerunning the tests or handling the rest?

@cyyeh
Copy link
Copy Markdown
Member

cyyeh commented Oct 26, 2023

@onlyjackfrost @cyyeh

Hi! It seems that some unit tests require access tokens, and I don't have the permission. As a result, the PR didn't pass the tests. Would you mind rerunning the tests or handling the rest?

@kenkoooo sure, we'll handle the rest. Thanks for submitting this PR! We'll also come up with better ways to help contributors like you easier to contribute to VulcanSQL.

@kenkoooo
Copy link
Copy Markdown
Contributor Author

@cyyeh Thanks a lot!

Copy link
Copy Markdown
Contributor

@onlyjackfrost onlyjackfrost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @kenkoooo

@onlyjackfrost onlyjackfrost merged commit 4c0c542 into Canner:develop Nov 30, 2023
@kenkoooo
Copy link
Copy Markdown
Contributor Author

kenkoooo commented Dec 4, 2023

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants